oslo.messaging 3.1.0 breaking ironic stable releases unit tests

[Lucas Alvares Gomes]

Example of error:

2015-12-08 14:07:48.276 | class RequestContextSerializer(messaging.RequestContextSerializer):
2015-12-08 14:07:48.276 | File "/home/jenkins/workspace/gate-ironic-python27/.tox/py27/lib/python2.7/abc.py", line 87, in __new__
2015-12-08 14:07:48.276 | cls = super(ABCMeta, mcls).__new__(mcls, name, bases, namespace)
2015-12-08 14:07:48.276 | TypeError: Error when calling the metaclass bases
2015-12-08 14:07:48.276 | metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases

More logs: http://logs.openstack.org/59/254759/1/check/gate-ironic-python27/9e4a526/console.html

Cause:

oslo.messaging was using debtcollector to decorate the RequestContextSerializer as deprecated and ran into this debt collector bug: https://bugs.launchpad.net/debtcollector/+bug/1520397

More:

This patch fixed the problem before the oslo.messaging release in Ironic master branch https://review.openstack.org/#/c/250571/1

[Matt Riedemann (mriedem)]

This is the revert to oslo.messaging:

https://review.openstack.org/#/c/254904/

We have to blacklist o.m 3.1.0 in g-r master and stable/liberty.

[Matt Riedemann (mriedem)]

This is the g-r blacklist change: https://review.openstack.org/#/c/254911/

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=(message:%5C%22class%20RequestContextSerializer(messaging.RequestContextSerializer):%5C%22%20OR%20message:%5C%22TypeError:%20'tuple'%20object%20is%20not%20callable%5C%22)%20AND%20tags:%5C%22console%5C%22%20AND%20project:%5C%22openstack/ironic%5C%22

[Matt Riedemann (mriedem)]

Question - why didn't the ironic dsvm gate jobs fail with the oslo.messaging 3.1.0 release? Why was it only the unit tests?

[Matt Riedemann (mriedem)]

Nevermind, it's a unit test only failure because of upper-constraints, that's applied to the dsvm jobs but not the unit test jobs.

[Davanum Srinivas (DIMS) (dims-v)]

I'd support https://review.openstack.org/#/c/254890/ as a fix for this problem

[Davanum Srinivas (DIMS) (dims-v)]

Theres a block on the specific version in g-r, which means unless https://review.openstack.org/#/c/254890/ is re-instated, the next oslo.messaging will break ironic again

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254904
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=576e6ccfb20aa754da41aa73977031ba0ac6aebb
Submitter: Jenkins
Branch: master

commit 576e6ccfb20aa754da41aa73977031ba0ac6aebb
Author: Jim Rollenhagen <email address hidden>
Date: Tue Dec 8 10:48:35 2015 -0800

    Revert "serializer: deprecate RequestContextSerializer"

    This reverts commit 196980dace199c412dfaec34568c2a2d66b95a45.

    There is a bug in debtcollector with using the remove decorator on
    abstract classes, which RequestContextSerializer is.
    https://bugs.launchpad.net/debtcollector/+bug/1520397

    The addition of debtcollector to requirements.txt is left in place
    because it is used elsewhere in the code by now.

    Partial-Bug: #1524041
    Change-Id: Ic3985707e941f7a7a1e039e702ce9219a3c741df