ironic.conf.sample not displaying deprecated configs

Bug #1519886 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Ruby Loo

Bug Description

ironic.conf.sample is only showing the deprecated configs whose names have changed, eg:

    # Size of executor thread pool. (integer value)
    # Deprecated group/name - [DEFAULT]/rpc_thread_pool_size
   #executor_thread_pool_size=64

For configs where the name hasn't changed but the group has, nothing is shown. Eg, the inspector-related configs were moved from [discoverd] to [inspector]:

    # whether to enable inspection using ironic-inspector (boolean
    # value)
    #enabled=false

We should show the deprecated group (and name). Eg:

    # whether to enable inspection using ironic-inspector (boolean
    # value)
    # Deprecated group/name - [discoverd]/enabled
    #enabled=false

Ruby Loo (rloo)
Changed in ironic:
assignee: nobody → Ruby Loo (rloo)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249912

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/249912
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9433f6f3b7670682ede17e5d3b6ddba79cff000a
Submitter: Jenkins
Branch: master

commit 9433f6f3b7670682ede17e5d3b6ddba79cff000a
Author: Ruby Loo <email address hidden>
Date: Wed Nov 25 16:54:49 2015 +0000

    Add deprecated config info in ironic.conf.sample

    ironic.conf.sample shows deprecated configs that have been
    moved to different groups and renamed. Deprecated configs are
    not being indicated if they moved to a different group but
    did not get renamed.

    This fixes it to show all deprecated configs.

    ironic.conf.sample was also updated to reflect other changes
    that have occurred since the last update.

    Change-Id: I608892a9735ecffc2c374330a4f0ee4e12ab6011
    Fixes-Bug: #1519886

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.