[RFE] Check for duplicates when enrolling a node

[Pradeep Varadarajulu]

Steps to reproduce:

1. Enroll the ironic node multiple times for the same baremetal using "pxe_iscsi_cimc_neutron" driver.

2. We are able to enroll multiple ironic nodes on same baremetal, there needs to be a validation here to check the enrollment of ironic node on same baremetal

stack@sap-controller1:~/devstack$ ironic node-create -d pxe_iscsi_cimc_neutron -i cimc_address=10.106.240.210 -i cimc_username=admin -i cimc_password=password -i deploy_kernel=42c44287-3574-4bc 8-9e4e-559674b1a679 -i deploy_ramdisk=c3390340-5446-42be-a3cb-d69537580932 -p cpus=4 -p memory_mb=65536 -p local_gb=100 -p cpu_arch=x86_64 -p capabilities="boot_option:local"
+--------------+--------------------------------------------------------------------------+
| Property | Value |
+--------------+--------------------------------------------------------------------------+
| uuid | caa89b06-2e86-4e94-afab-509ba4c35ec0 |
| driver_info | {u'cimc_address': u'10.106.240.210', u'cimc_username': u'admin', |
| | u'deploy_ramdisk': u'c3390340-5446-42be-a3cb-d69537580932', |
| | u'deploy_kernel': u'42c44287-3574-4bc8-9e4e-559674b1a679', |
| | u'cimc_password': u'******'} |
| extra | {} |
| driver | pxe_iscsi_cimc_neutron |
| chassis_uuid | |
| properties | {u'memory_mb': 65536, u'cpu_arch': u'x86_64', u'local_gb': 100, u'cpus': |
| | 4, u'capabilities': u'boot_option:local'} |
| name | None |
+--------------+--------------------------------------------------------------------------+
stack@sap-controller1:~/devstack$ ironic node-list
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| caa89b06-2e86-4e94-afab-509ba4c35ec0 | None | None | None | available | False |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
stack@sap-controller1:~/devstack$ ironic node-create -d pxe_iscsi_cimc_neutron -i cimc_address=10.106.240.210 -i cimc_username=admin -i cimc_password=password -i deploy_kernel=42c44287-3574-4bc 8-9e4e-559674b1a679 -i deploy_ramdisk=c3390340-5446-42be-a3cb-d69537580932 -p cpus=4 -p memory_mb=65536 -p local_gb=100 -p cpu_arch=x86_64 -p capabilities="boot_option:local"
+--------------+--------------------------------------------------------------------------+
| Property | Value |
+--------------+--------------------------------------------------------------------------+
| uuid | 341ac44d-31d5-4120-bb60-c59993186375 |
| driver_info | {u'cimc_address': u'10.106.240.210', u'cimc_username': u'admin', |
| | u'deploy_ramdisk': u'c3390340-5446-42be-a3cb-d69537580932', |
| | u'deploy_kernel': u'42c44287-3574-4bc8-9e4e-559674b1a679', |
| | u'cimc_password': u'******'} |
| extra | {} |
| driver | pxe_iscsi_cimc_neutron |
| chassis_uuid | |
| properties | {u'memory_mb': 65536, u'cpu_arch': u'x86_64', u'local_gb': 100, u'cpus': |
| | 4, u'capabilities': u'boot_option:local'} |
| name | None |
+--------------+--------------------------------------------------------------------------+
stack@sap-controller1:~/devstack$ ironic node-list
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+
| caa89b06-2e86-4e94-afab-509ba4c35ec0 | None | None | None | available | False |
| 341ac44d-31d5-4120-bb60-c59993186375 | None | None | None | available | False |
+--------------------------------------+------+---------------+-------------+--------------------+-------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/256356

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.openstack.org/256356
Reason: Hi! This has been around for 9 months with negative feedback, so I'm abandoning it. I do think it's a valuable feature to have, and I think we should start with a spec.

[Dmitry Tantsur (divius)]

This is a feature request actually, and I'd like to see a spec on it first: http://docs.openstack.org/developer/ironic/dev/code-contribution-guide.html#ironic-specs-process

[Michael Turek (mjturek)]

This wishlist bug has been open more than a year without any activity. I'm going to move it to "Opinion / Wishlist", which is an easily-obtainable queue of older requests that have come on. This bug can be reopened (set back to "New") if someone decides to work on this.

[Ruby Loo (rloo)]

Hi Michael, I think there's validity to this, but as mentioned above, it needs a spec; its better to change the status back to 'Confirmed' (which I'll do).

Zhenguo, since there hasn't been any activity from you, I'm going to make this available for others to take a stab at. Feel free to assign it to yourself if you plan on working on it in the near future.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zhenguo Niu (<email address hidden>) on branch: master
Review: https://review.opendev.org/296357

[Julia Kreger (juliaashleykreger)]

In discussion with contributors, we believe this is invalid/wont-fix.

Specifically, depending on the hardware, you may have many different "nodes" using the same BMC with one minor parameter difference. Realistically we can't really de-duplicate them without encoding all that extra logic.