agent_ilo driver uses it's own CONF variable for erase device priority

Bug #1515871 reported by Ramakrishnan G (rameshg87)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

All other drivers including pxe_*, iscsi_* and agent_* drivers use CONF.deploy.erase_devices_priority for configuring the priority of erase devices clean step. agent_ilo driver should use the same. The previous config should be deprecated.

Tags: ilo
Shuquan Huang (shuquan)
Changed in ironic:
assignee: nobody → Shuquan Huang (shuquan)
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
tags: added: ilo
Revision history for this message
Ruby Loo (rloo) wrote :

Hi Shuquan, are you working on this? If so, when do you think there will be a patch to address this?

Revision history for this message
Shuquan Huang (shuquan) wrote :

Hi Ruby, sorry for the late reply due to new year vacation. Yes, I'm still working on it. I'll submit a patch soon. :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/270637

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Lucas Alvares Gomes (<email address hidden>) on branch: master
Review: https://review.openstack.org/270637
Reason: 6 months with no updates, I will take this over

Changed in ironic:
assignee: Shuquan Huang (shuquan) → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342114

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/342114
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0fcf2e8b51e7dbbcde6d4480b8a7b9c807651546
Submitter: Jenkins
Branch: master

commit 0fcf2e8b51e7dbbcde6d4480b8a7b9c807651546
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Jul 14 12:20:40 2016 +0100

    Deprecate [ilo]/clean_priority_erase_devices config

    The [ilo]/clean_priority_erase_devices configuration option is
    duplicated by [deploy]/erase_devices_priority, this patch is marking the
    ilo configuration as deprecated.

    The ironic.conf.sample was also updated to reflect the changes.

    Closes-Bug: #1515871
    Change-Id: I2bf18e35d97160d31a51c8447745bfd60c099af2

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342545

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/342545
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c46da47af9bd0c0609650e3edc36b05546657f15
Submitter: Jenkins
Branch: master

commit c46da47af9bd0c0609650e3edc36b05546657f15
Author: Shivanand Tendulker <email address hidden>
Date: Thu Jul 14 21:00:33 2016 -0700

    Follow-up patch of 0fcf2e8b51e7dbbcde6d4480b8a7b9c807651546

    This commit removes documentation related to deprecated config
    parameter [ilo]/clean_priority_erase_devices

    Closes-Bug: #1515871

    Change-Id: I9a4e063138db53c9ce2a18877e86d5873cb30a85

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/ironic 6.1.0

This issue was fixed in the openstack/ironic 6.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.