Set boot device while server is on

[Thiago Paiva Brito]

The agent vendor interface sets the boot device of the machine while it is yet powered on in [1] and just after calls the reboot_and_finish_deploy method.

Some technologies (such as OneView) requires that the server is powered off to switch the primary boot device of the node.

[1]https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L420

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232186

[Dmitry Tantsur (divius)]

Hi, thank you for your report! Could you please add references to "some technologies" to the description?

[Paul Morris (paul-morris-0003)]

I can probably add some commentary here. I have experienced some challenges using the agent_ssh driver with ironic and bifrost over the last week which seem to be related when targeting VirtualBox hosted on Mac OS X.

The provisioning appears to have gone fine up until the time the agent_ssh driver attempts to change the boot device from net to disk1, at which point, VirtualBox throws an error about the session for that VM being locked.

Details you might find useful:

I am running VirtualBox 5.0.10, and Mac OS X 10.11.1. Which means that thanks to SIP, I had to alter the path for VBoxManage in the driver, as I can't just add a symlink on my ssh target. (You can't write to /usr with SIP enabled on El Capitan. Modding the path allowed it to work with no other issues for my test case, however. Well aside from the aforementioned issue regarding the boot device change.)

The relevant line from the error logging to cover this event is as follows:

Dec 4 20:25:05 somehostname ironic-conductor: Stderr: u'VBoxManage: error: The machine \'testvm1\' is already locked for a session (or being unlocked)\nVBoxManage: error: Details: code VBOX_E_INVALID_OBJECT_STATE (0x80bb0007), component MachineWrap, interface IMachine, callee nsISupports\nVBoxManage: error: Context: "LockMachine(a->session, LockType_Write)" at line 493 of file VBoxManageModifyVM.cpp\n'.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Thiago Paiva Brito (<email address hidden>) on branch: master
Review: https://review.openstack.org/232186

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/360330

[Galyna Zholtkevych (gzholtkevych)]

The fix proposed only for oneview driver, because no more technologies are noticed to require this.
If more drivers will do, the patchset will be updated then

[OpenStack Infra (hudson-openstack)]

Change abandoned by Galyna Zholtkevych (<email address hidden>) on branch: master
Review: https://review.openstack.org/360330
Reason: Abandoning this since another more appropriate work in this direction started

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464212

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482209

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482209
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8f45317d4345872c050b2fa347f7be033556d2f5
Submitter: Jenkins
Branch: master

commit 8f45317d4345872c050b2fa347f7be033556d2f5
Author: Xavier <email address hidden>
Date: Wed Jul 5 11:13:41 2017 -0300

    Removes agent mixin from oneview drivers

    This patch removes the agent mixin interface from oneview
    drivers and adds a flag based solution instead. Once a set
    boot device operation needs to be performed, the operation
    is stored to driver_internal_info until the server power
    on. Before power the server on again, the operation stored
    is performed and then the server is powered on.

    Change-Id: I8dabf7ef1ff6e44c062310c5cb3509e545585c0a
    Closes-Bug: #1503855

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/489598

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/490095

[OpenStack Infra (hudson-openstack)]

Change abandoned by Xavier (<email address hidden>) on branch: master
Review: https://review.openstack.org/408298

[OpenStack Infra (hudson-openstack)]

Change abandoned by Xavier (<email address hidden>) on branch: master
Review: https://review.openstack.org/464212

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.0.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/490095
Reason: The last ironic release for Newton was done, and we're ready to EOL the branch. Thus I have to abandon this change, thanks for understanding.