IPA installations can hang on (some) real hardware

[Dan Prince]

Trying to use the new Ironic Python Agent deployment ramdisk w/ the latest Ironic. The deployment seems to go fine, the instances goes to an ACTIVE state and all looks well. After provisioning however the machine never seems to boot (this is a real machine). The issue seems to be that IPA shuts down the compute, Ironic conductor then sends a POWER_ON... but with some power drivers (I'm using iboot, but probably any "external" power controller too) the machine stays in a offline state (it has power, but isn't booted). This is because I rely on an actual power reboot (physical power has to be cycled in order for the machines to know it needs to boot, this is how I configure it in the BIOS).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232157

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232157
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d9857a41626ab8caafb0d845653d29041176f7d7
Submitter: Jenkins
Branch: master

commit d9857a41626ab8caafb0d845653d29041176f7d7
Author: Dan Prince <email address hidden>
Date: Wed Oct 7 15:14:48 2015 -0400

    Use power manager to reboot in agent deployments

    This patch updates the reboot_and_finish_deploy function
    for IPA based deployments so that we use the power manager
    to send a proper REBOOT command to the instance after
    trying to soft power off the client. This is important
    for machines that use "external" power controllers which
    may not know the power state of the host machine. In
    such configurations users may rely on BIOS boot on power on
    settings to active their machines. Simply sending a POWER_ON
    in such configurations doesn't work because the machine is
    already in a POWER_ON state (because it just deployed) so
    nothing happens (the machined has power but isn't booted).

    Change-Id: If5deddc1ecb069b68f2f1d766eb058691ca280af
    Closes-bug: #1503839