Missing mock in irmc driver unit test

[Yuriy Zveryanskyy]

There is missing _check_share_fs_mounted() mock in IRMCVirtualMediaAgentVendorInterfaceTestCase class. Depends on test order unit tests can fail, example: http://logs.openstack.org/04/229904/3/gate/gate-ironic-python27/f507016/console.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231900

[Naohiro Tamura (naohirot)]

Yes, this is exactly the case I wondered if iRMC did something wrong or not in the following gerrit patch

Imported Translations from Zanata
https://review.openstack.org/#/c/229258/

> Naohiro Tamura Sep 30 5:59 PM
> Patch Set 1: Code-Review-1
> I noticed that gate-ironic-python34 failed due to irmc '/remote_image_share_root', need to check.

Thanks.
Nahiro

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231900
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5b867585ebbc196f2311f355a923fc8fc0c780a2
Submitter: Jenkins
Branch: master

commit 5b867585ebbc196f2311f355a923fc8fc0c780a2
Author: Yuriy Zveryanskyy <email address hidden>
Date: Wed Oct 7 12:04:36 2015 +0300

    Fix irmc driver unit test

    This patch adds missing mock to
    "IRMCVirtualMediaAgentVendorInterfaceTestCase", also
    addCleanup() method added.

    Closes-bug: #1503603
    Change-Id: I28ff947148fb2d840b69306cfcdbd53fd4205cd1

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/232946

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232946
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=97750967e50fb0bd4f6ff751e4a8c6d60ec055fd
Submitter: Jenkins
Branch: master

commit 97750967e50fb0bd4f6ff751e4a8c6d60ec055fd
Author: Naohiro Tamura <email address hidden>
Date: Fri Oct 9 17:05:44 2015 +0900

    Prevent iRMC unit test from potential failure at the gate

    This patch adds the missing mock patcher.stop() which corresponds to
    patcher.start() so as not to be a cause of failure at the gate.

    Change-Id: I6d3cb6f70550d9f36e33b4b9b5f493784dc0f5dc
    Related-Bug: #1503603