Rolling upgrades: backward incompatible changes in versioned objects

Bug #1502895 reported by Grzegorz Grasza
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Tan Lin

Bug Description

In the past, changes to versioned objects were done without implementing the obj_make_compatible method, which breaks rolling upgrades (upgrades when Ironic services are run at different versions simultaneously)
To prevent introduction of incompatible changes to versioned objects an object version hash test should be introduced, together with documentation.

This was recently discussed in Magnum:

http://lists.openstack.org/pipermail/openstack-dev/2015-August/072975.html

As a result, two patches were merged:

https://review.openstack.org/#/c/217342/ - implementation

https://review.openstack.org/#/c/220539/ - documentation

Tags: conductor
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
tags: added: conductor
Tan Lin (tan-lin-good)
Changed in ironic:
assignee: nobody → Tan Lin (tan-lin-good)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/249624

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/249624
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=74bd3b18659daf7571f8addbd870b48e614e1f73
Submitter: Jenkins
Branch: master

commit 74bd3b18659daf7571f8addbd870b48e614e1f73
Author: Lin Tan <email address hidden>
Date: Wed Nov 25 15:49:05 2015 +0800

    Add a test to enforce object version bump correctly

    Add a test to help developers to check if the change of objects
    need a version bump.

    Any changes of object fields or remotable methods need to bump
    its version. Use oslo_versionobjects to generate the hashes and
    compare with a pre-define hash map.

    Change-Id: I5c12ab72937f05ba46eb58d049f9b7fc7c806218
    Closes-Bug: 1502895
    Implements: blueprint online-upgrade-support

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic 4.3.0

This issue was fixed in the openstack/ironic 4.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.