IPA: missing dmidecode binary (it's missing ipmitool as well)

[Lucas Alvares Gomes]

The images we distribute for IPA is missing dmidecode, even tho it's a WARNING it may confuse people when they see the error on the console when IPA boots up.

ERROR:

[ 96.315677] systemd-nspawn[428]: Spawning container ironic_python_agent on /opt/ironic-python-agent. Press ^] three times within 1s to abort execution.
[ 96.380563] systemd-nspawn[428]: /etc/localtime is not a symlink, not updating container timezone.
[ 104.045376] systemd-nspawn[428]: /usr/local/lib/python2.7/dist-packages/pecan/__init__.py:122: RuntimeWarning: `static_root` is only used when `debug` is True, ignoring
[ 104.051676] systemd-nspawn[428]: RuntimeWarning
[ 104.077376] systemd-nspawn[428]: 2015-09-10 15:17:47.110 431 INFO root [-] Hardware manager found: ironic_python_agent.hardware:GenericHardwareManager
[ 104.512372] systemd-nspawn[428]: 2015-09-10 15:17:47.536 431 WARNING root [-] Cannot get real physical memory size: Unexpected error while running command.
[ 104.519633] systemd-nspawn[428]: Command: dmidecode --type memory | grep Size
[ 104.532859] systemd-nspawn[428]: Exit code: 1
[ 104.550720] systemd-nspawn[428]: Stdout: u''
[ 104.558816] systemd-nspawn[428]: Stderr: u'/bin/sh: 1: dmidecode: not found\n'
[ 105.087424] systemd-nspawn[428]: 2015-09-10 15:17:48.124 431 INFO ironic_python_agent.agent [-] starting heartbeater
[ 105.250406] systemd-nspawn[428]: 2015-09-10 15:17:48.288 431 INFO ironic_python_agent.agent [-] heartbeat successful
[ 105.260795] systemd-nspawn[428]: 2015-09-10 15:17:48.298 431 INFO ironic_python_agent.agent [-] sleeping before next heartbeat, interval: 15.3926385506
[ 105.371499] systemd-nspawn[428]: 2015-09-10 15:17:48.409 431 INFO root [-] Command clean.get_clean_steps completed: <ironic_python_agent.extensions.base.SyncCommandResult object at 0x7f7159f8de90>
[ 105.396616] systemd-nspawn[428]: 172.24.4.1 - - [10/Sep/2015 15:17:48] "POST /v1/commands?wait=true HTTP/1.1" 200 1895

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222247

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222247
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=f683a783af2898c4753ad2fc2dce29a88a225976
Submitter: Jenkins
Branch: master

commit f683a783af2898c4753ad2fc2dce29a88a225976
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Sep 10 16:24:11 2015 +0100

    Install "dmidecode" and "ipmitool" by default

    The get_memory() method relies on dmidecode to get the total amount of
    RAM present in the node but, but by default dmidecode is not installed
    in the image.

    Same for get_bmc_address() and ipmitool.

    This patch fixes both cases by installing the "dmidecode" and "ipmitool"
    packages when generating the CoreOS image of IPA.

    Closes-Bug: 1494367
    Change-Id: Ibded7bd533d604cf21a3b60afd396dc7b8b8750b