state machine incorrectly models CLEANFAIL -> CLEANING transition
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Fix Released
|
Medium
|
Ruby Loo |
Bug Description
The state machine incorrectly models the transitions around the CLEANFAIL state.
For reference, I'll quote the spec:
http://
CLEANING
Nodes in the CLEANING state are being scrubbed in preparation to being made AVAILABLE. Good candidates for CLEANING tasks include:
[snip...]
Management of CLEANING tasks should be handled in the same fashion as ZAPPING tasks.
ZAPFAIL
Nodes that transition into ZAPFAIL will automatically enter maintenance mode, as failure to ZAP a machine usually indicates a hardware failure or something else that requires remote hands to fix.
Here is the incorrect code:
204 # Add clean* states
205 machine.
206 machine.
...
262 # If cleaning fails, wait for operator intervention
263 machine.
264
265 # A node that fails cleaning may be put back through cleaning
266 machine.
267
268 # An operator may want to hold a CLEANFAIL node in operator for zapping or
269 # outside-of-Ironic operations (like replacing hardware)
270 machine.
Changed in ironic: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → liberty-1 |
Changed in ironic: | |
assignee: | nobody → Ruby Loo (rloo) |
Changed in ironic: | |
milestone: | none → 4.0.0 |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/176032
Review: https:/