IPA deploy driver gives incomprehensible error message when using partition images

[Jim Rollenhagen]

Clearly using a partition image should fail, however the error message could be better:

Current error message:
17:24:16 jgrimm | anyone seen this error before?->ConfigDriveWriteError', u'details': u'Writing configdrive to device /dev/sda failed with exit code 1. stdout: copy_configdrive_to_disk.sh: Adding configdrive partition to /dev/sda\ncopy_configdrive_to_disk.sh: Error creating configdrive on /dev/sda\n. stderr: partx: /dev/sda: failed to read partition table\nparted: invalid token: primary\nError: Expecting a file system type.

We should verify the image is suitable up front, before attempting to deploy it.

[Jon Grimm (jgrimm)]

FWIW, the image I created was created via DIB and successfullly deployed with pxe_ipmitool.

Nothing fancy, just:
  disk-image-create -a amd64 -u fedora -o my-image

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/164440

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/164440
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=dc4947438bbb88cc4dbd08a3ff7279b5e7ea1590
Submitter: Jenkins
Branch: master

commit dc4947438bbb88cc4dbd08a3ff7279b5e7ea1590
Author: Sirushti Murugesan <email address hidden>
Date: Sat Mar 14 21:51:00 2015 +0530

    Raise exception for Agent Deploy driver when using partition images

    Also, fixed some tests related to common code agent base vendor.

    Implements blueprint whole-disk-image-support
    Closes-Bug: #1430454

    Change-Id: Ibca9fee3ba86ee29ac9fdcdf19bca6c45bb4856f