| 2015-03-04 16:20:37 |
Vladyslav Drok |
description |
AgentDeploy.take_over method has the following code:
provider = dhcp_factory.DHCPFactory()
provider.update_dhcp(task, CONF.agent.agent_pxe_bootfile_name)
which seems to be incorreact, as second argument to update_dhcp should be a list of dicts, as mentioned in ironic.common.dhcp_provider https://github.com/openstack/ironic/blob/master/ironic/common/dhcp_factory.py#L85-L90 :
def update_dhcp(self, task, dhcp_opts):
"""Send or update the DHCP BOOT options for this node.
:param task: A TaskManager instance.
:param dhcp_opts: this will be a list of dicts, e.g.
::
[{'opt_name': 'bootfile-name',
'opt_value': 'pxelinux.0'},
{'opt_name': 'server-ip-address',
'opt_value': '123.123.123.456'},
{'opt_name': 'tftp-server',
'opt_value': '123.123.123.123'}]
""" |
AgentDeploy.take_over method has the following code:
provider = dhcp_factory.DHCPFactory()
provider.update_dhcp(task, CONF.agent.agent_pxe_bootfile_name)
which seems to be incorrect, as second argument to update_dhcp should be a list of dicts, as mentioned in https://github.com/openstack/ironic/blob/master/ironic/common/dhcp_factory.py#L85-L90 :
def update_dhcp(self, task, dhcp_opts):
"""Send or update the DHCP BOOT options for this node.
:param task: A TaskManager instance.
:param dhcp_opts: this will be a list of dicts, e.g.
::
[{'opt_name': 'bootfile-name',
'opt_value': 'pxelinux.0'},
{'opt_name': 'server-ip-address',
'opt_value': '123.123.123.456'},
{'opt_name': 'tftp-server',
'opt_value': '123.123.123.123'}]
""" |
|
