destroy_port fails to delete the port even if the node is locked by the same process.

Bug #1427597 reported by Nisha Agarwal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Nisha Agarwal

Bug Description

the method destroy_port() in ironic/db/sqlalchemy/api.py doesnt allow the port to be deleted even if the port belongs to the same node on which it already has the lock. This causes issues for ilo inspection which tries to deletes the port for the NIC which is no longer associated with the node.

Dmitry Tantsur (divius)
Changed in ironic:
status: New → Confirmed
importance: Undecided → Medium
Changed in ironic:
assignee: nobody → Nisha Agarwal (agarwalnisha1980)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/161861

Changed in ironic:
status: Confirmed → In Progress
aeva black (tenbrae)
Changed in ironic:
milestone: none → kilo-3
Changed in ironic:
assignee: Nisha Agarwal (agarwalnisha1980) → Ramakrishnan G (rameshg87)
Changed in ironic:
assignee: Ramakrishnan G (rameshg87) → Nisha Agarwal (agarwalnisha1980)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/161861
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fdd4216a4fdbd5763bfe2bf506d8f04aaaaadf83
Submitter: Jenkins
Branch: master

commit fdd4216a4fdbd5763bfe2bf506d8f04aaaaadf83
Author: Nisha Agarwal <email address hidden>
Date: Thu Mar 5 09:20:53 2015 -0800

    ironic port deletion fails even if node is locked by same process

    the reservation check at db layer prevents the port to be deleted
    if a process has exclusive lock on the node and is trying to
    delete the port

    Closes-Bug: 1427597

    Change-Id: I36e26b7273c2e12479ed7cd15fc7628f29fd6652

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.