iSCSI login depends on fix length sleep to wait for connections to become active

Bug #1415117 reported by Chris Krelle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Chris Krelle

Bug Description

The iSCSI login depends on a hard coded sleep value. This may not be the best approach. We should actively check for the connection to become active. The amount of time should also be adjustable to account for environments where the connection may take a little longer then allotted for with the hard coded sleep value.

Tags: pxe
Chris Krelle (nobodycam)
description: updated
Changed in ironic:
assignee: nobody → Chris Krelle (nobodycam)
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Medium
tags: added: pxe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/150187
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=46067160e6787631fb5a55193a02794449f22ebf
Submitter: Jenkins
Branch: master

commit 46067160e6787631fb5a55193a02794449f22ebf
Author: Chris Krelle <email address hidden>
Date: Mon Jan 26 15:58:05 2015 -0800

    Actively check iSCSI connection after login

    This replaces the sleep command at the end of the login_iscsi fuction
    with an active check and a forced lun update. These two things help ensure
    the connection sees all luns on the iSCSI device before attempting to write
    to it. It also adds a configurable option to allow users to be able to
    customize the number of attempts for their environment.

    Also add some very basic logging to aid in deploy debuging

    Change-Id: I68c9f9f86f5f113bb111c0f4fd83216ae0659d36
    Closes-bug: #1415117
    Partial-Bug: #1286374

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
aeva black (tenbrae) wrote :

Fix was partially reverted, so I am re-opening the bug

Changed in ironic:
status: Fix Committed → In Progress
Changed in ironic:
status: In Progress → Fix Committed
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.