set-console-mode should validate the configuration

[Haomeng,Wang]

node-set-console-mode run with error but no any message we get from client:

[root@localhost ~]# ironic node-set-console-mode 65fe14d5-df35-4895-90ab-377a79c64375 true

[root@localhost ~]# ironic node-get-console 65fe14d5-df35-4895-90ab-377a79c64375

+-----------------+-------+
| Property | Value |
+-----------------+-------+
| console_enabled | False |
| console_info | None |
+-----------------+-------+

And can not get console info, check the conductor log, found there are some message as below:

2014-12-15 02:55:22.947 9530 DEBUG oslo.messaging._drivers.amqp [-] UNIQUE_ID is 4fcb5901bdb04f26b1887c4895cf25ad. _add_unique_id /usr/lib/python2.7/site-packages/oslo/messaging/_drivers/amqp.py:249
2014-12-15 02:55:22.949 9530 DEBUG ironic.drivers.modules.console_utils [-] Running subprocess: shellinaboxd -t -p 1234 --background=/tmp/65fe14d5-df35-4895-90ab-377a79c64375.pid -s /:989:987:HOME:ipmitool -H 9.119.58.64 -I lanplus -U USERID -f /tmp/65fe14d5-df35-4895-90ab-377a79c64375.pw -v sol activate start_shellinabox_console /usr/lib/python2.7/site-packages/ironic/drivers/modules/console_utils.py:202
2014-12-15 02:55:22.959 9530 WARNING ironic.drivers.modules.console_utils [-] [Errno 2] No such file or directory
Command: shellinaboxd -t -p 1234 --background=/tmp/65fe14d5-df35-4895-90ab-377a79c64375.pid -s /:989:987:HOME:ipmitool -H 9.119.58.64 -I lanplus -U USERID -f /tmp/65fe14d5-df35-4895-90ab-377a79c64375.pw -v sol activate

Can not find the 1234 port is listening:

[root@localhost ~]# netstat -an|grep 1234
[root@localhost ~]#

The operation is failed, but we just see some WARNING in the log, so we need to valid all the required operation during node-set-console-mode call and let user to get them ready and retry.

[Haomeng,Wang (whaom)]

[root@localhost ~]# ironic node-show 65fe14d5-df35-4895-90ab-377a79c64375
+------------------------+--------------------------------------------------------------------------+
| Property | Value |
+------------------------+--------------------------------------------------------------------------+
| instance_uuid | None |
| target_power_state | None |
| properties | {} |
| maintenance | False |
| driver_info | {u'pxe_deploy_ramdisk': u'0aec86cf-55d1-4ed8-83a5-3d4fe35651f2', |
| | u'ipmi_terminal_port': u'1234', u'ipmi_username': u'USERID', |
| | u'ipmi_address': u'9.119.58.64', u'ipmi_password': u'passw1rd', |
| | u'pxe_deploy_kernel': u'287a200f-5356-47c5-9753-839ea8ff861c'} |
| extra | {} |
| last_error | Error enabling the console on node 65fe14d5-df35-4895-90ab-377a79c64375. |
| | Reason: Console subprocess failed to start. [Errno 2] No such file or |
| | directory Command: shellinaboxd -t -p 1234 |
| | --background=/tmp/65fe14d5-df35-4895-90ab-377a79c64375.pid -s |
| | /:989:987:HOME:ipmitool -H 9.119.58.64 -I lanplus -U USERID -f |
| | /tmp/65fe14d5-df35-4895-90ab-377a79c64375.pw -v sol activate |
| created_at | 2014-12-09T01:15:01+00:00 |
| target_provision_state | None |
| driver | pxe_ipmitool |
| updated_at | 2014-12-15T10:32:37+00:00 |
| instance_info | {u'ramdisk': u'afa3c3c4-e6f3-4621-80f0-a322656454d7', u'kernel': |
| | u'7e218480-56e1-4a70-8f3d-58c3bd1e9cd0', u'root_gb': u'10', |
| | u'image_source': u'caf889d0-7ea0-4205-882e-933192a598ea', u'deploy_key': |
| | u'MVSDO4978Z3YHQJ3U5UWESUVAFL3H2RV'} |
| chassis_uuid | |
| provision_state | active |
| reservation | None |
| power_state | power on |
| console_enabled | False ...

[Zhenguo Niu (niu-zglinux)]

hi Sandhya, are you still working on this?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235159

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Iury Gregory Melo Ferreira <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/235159
Reason: No updates since 2017, re open if necessary.

[Iury Gregory Melo Ferreira (iurygregory)]

No updates since 2017, marking as invalid