ilo_deploy driver has poor test coverage for continue_deploy

Bug #1402019 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Anusha

Bug Description

There is only one test handling an error path for the _continue_deploy method, and it merely asserts that an invalid initial state results in a LOG message being written out.

It would be better to assert that, when given a valid initial condition, any exceptions raised by methods called from _continue_deploy are handled appropriately.

aeva black (tenbrae)
affects: hacking → ironic
tags: added: driver
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: low-hanging-fruit
Anusha (anusha-iiitm)
Changed in ironic:
assignee: nobody → Anusha (anusha-iiitm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142985

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/142985
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fc07c154e4bb42908d4a0d13ff1ed5f7f14b8af7
Submitter: Jenkins
Branch: master

commit fc07c154e4bb42908d4a0d13ff1ed5f7f14b8af7
Author: Anusha Ramineni <email address hidden>
Date: Fri Dec 19 10:41:49 2014 +0530

    Add tests for ilo_deploy driver

    ilo_deploy driver has poor test coverage for continue_deploy. This
    commit is to update the tests for the same.

    Change-Id: Ib6ffdc6e1de56df2d0e1d36af94cb1d25aea84c1
    Closes-Bug: 1402019

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.