image_source can break deployment if IPA is used

[Vladyslav Drok]

If image_source in instance_info dictionary specified in 'glance://image-uuid' format, it will break deployment, as IPA will try to write this image to /tmp/{image_source} and will fail to create such file, raising IOError: [Errno 2] No such file or directory.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/139988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/139988
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5b05cab7a648bb4bb9363ba45bff3ce8292ca5b4
Submitter: Jenkins
Branch: master

commit 5b05cab7a648bb4bb9363ba45bff3ce8292ca5b4
Author: Vladyslav Drok <email address hidden>
Date: Mon Dec 8 14:30:09 2014 +0200

    Fix image_info passed to IPA for image download

    It's possible to specify instance_info['image_source'] to be a value
    like 'glance://uuid'. When using AgentDeploy, image_source is passed
    to IPA in image_info dictionary in 'id' field without modification,
    and IPA tries to download image to /tmp/{id} location. Deployment
    fails as /tmp/glance://uuid is invalid location.

    In this change image_source is split to ensure that uuid will be used
    to name the file.

    Closes-bug: #1400156
    Change-Id: Id3658d2a32c87867d828bc3b3fecc94e514a4526