VendorInterface.validate() not regard 'method' as a mandatory argument

Bug #1394470 reported by Tan Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Tan Lin

Bug Description

def validate(self, task, **kwargs):
should be
def validate(self, task, method, **kwargs):

'method' should be a mandatory argument rather in kwargs.

Tags: driver
Tan Lin (tan-lin-good)
Changed in ironic:
assignee: nobody → Tan Lin (tan-lin-good)
Dmitry Tantsur (divius)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: driver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144265

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/144265
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9650c88d97c46f8d03921674d2c92cc1d0c9b0d9
Submitter: Jenkins
Branch: master

commit 9650c88d97c46f8d03921674d2c92cc1d0c9b0d9
Author: Tan Lin <email address hidden>
Date: Mon Dec 29 22:45:29 2014 +0000

    Make 'method' explicit for VendorInterface.validate()

    Method should be more explicit than only having it via kwargs.

    Closes-Bug: #1394470
    Change-Id: I6a55e1be013629e22c384b968699980e83ae0cd3

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.