validate() is not called in the driver_vendor_passthru()

Bug #1391580 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Tan Lin

Bug Description

The vendor.validate() method is not called as part of the driver_vendor_passthru() call on the Ironic conductor. The reason I believe is because vendor.validate() expects a task object as the first parameter and in the driver_vendor_passthru() we don't have it because there's no Node to be acquired.

I see it being fixed in two ways:

1) Modify the validate() to make task optional

2) Add a new driver_validate() as part of the VendorInterface

I think 2) is more reasonable.

Changed in ironic:
importance: Undecided → Medium
Tan Lin (tan-lin-good)
Changed in ironic:
assignee: nobody → Tan Lin (tan-lin-good)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134184

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/134184
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d0e7bd2973dd5ec03544b55965c805926d210eb7
Submitter: Jenkins
Branch: master

commit d0e7bd2973dd5ec03544b55965c805926d210eb7
Author: Tan Lin <email address hidden>
Date: Thu Nov 13 22:25:08 2014 +0800

    Add driver_validate()

    vendor.driver_vendor_passthru() should be validated before called
    on Ironic conductor, like vendor_passthru(). Add a new method
    driver_validate() to support this.

    Change-Id: Idff802cece01940b8ade34fa343f1bc8e76f1630
    Closes-Bug: #1391580

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.