Conductor stops heartbeating when exception is raised in heartbeat worker

[Jim Rollenhagen]

If an unexpected exception is raised from touch_conductor() (e.g. mysql goes away), the worker will die. The conductor will continue to run without heartbeating, making it effectively useless.

We need to think about how to handle other exceptions that may come up, but I tend to think if the conductor fails to connect to mysql, it should continue to attempt a heartbeat (because mysql could come back).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129301

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129301
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2cba7f557abfe2525913ef4ae1310e1d1e23f96c
Submitter: Jenkins
Branch: master

commit 2cba7f557abfe2525913ef4ae1310e1d1e23f96c
Author: Jim Rollenhagen <email address hidden>
Date: Fri Oct 17 08:30:12 2014 -0700

    Continue heartbeating after DB connection failure

    If the conductor cannot connect to the database to heartbeat,
    it should retry on the next heartbeat instead of the heartbeat
    thread dying.

    Partial-Bug: 1382589

    Change-Id: I994994e1e8ec4760b677a4ab613ee059c5787900

[Jim Rollenhagen (jim-rollenhagen)]

I can't think of many other errors this could hit... going to close it out.