validation of deploy interface references instance_info

[aeva black]

When calling "ironic node-validate NNNN" on a node which uses any of the pxe_* family of drivers, if the node.instance_info does not contain "image_source" or "root_gb", then the deploy interface will fail to validate. This is confusing because these fields are not part of driver_info, whereas all other errors reported by node-validate reference parameters which are part of driver_info.

Example:

deva@devstack:~/devstack$ ironic node-show a8cb6624-0d9f-4882-affc-046ebb96ec92
| driver_info | {u'ipmi_address': u'1.2.3.4', u'ipmi_username': u'admin', |
| | u'ipmi_password': u'adminpass'} |
| instance_info | {} |

deva@devstack:~/devstack$ ironic node-validate a8cb6624-0d9f-4882-affc-046ebb96ec92
| deploy | False | Cannot validate iSCSI deploy. The following parameters were not passed to ironic: ['root_gb', 'image_source'] |

deva@devstack:~/devstack$ ironic node-update a8cb6624-0d9f-4882-affc-046ebb96ec92 add instance_info/root_gb=10 instance_info/image_source=f35a1006-fd03-4c41-abef-f15c38d3b1a6
| instance_info | {u'root_gb': u'10', u'image_source': u'f35a1006-fd03-4c41-abef- |
| | f15c38d3b1a6'} |

deva@devstack:~/devstack$ ironic node-validate a8cb6624-0d9f-4882-affc-046ebb96ec92
| deploy | False | Cannot validate PXE bootloader. The following parameters were not passed to ironic: ['pxe_deploy_ramdisk', 'pxe_deploy_kernel'] |

[Anusha (anusha-iiitm)]

Isn't this duplicate of #Bug 1379911?

[Rakesh H S (rh-s)]

Hi Anusha,

Let me know if https://review.openstack.org/#/c/128862/ fixes this issue.

Regards,
Rakesh

[Jim Rollenhagen (jim-rollenhagen)]

This is fixed by 128862, and is a duplicate of 1379911. Closing.