nova driver exceptions on instance delete: TypeError: power_off() takes exactly 2 arguments (4 given)

[Adam Gandelman]

  0 2014-08-21 12:43:28.603 ERROR oslo.messaging.rpc.dispatcher [req-4d05e858-ba7d-479f-bb60-5c138d63e116 TestNetworkAdvancedServerOps-1615212308 TestNetworkAdvancedServerOps-1475768323] Exception during message h andling: power_off() takes exactly 2 arguments (4 given)
  1 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
  2 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 134, in _dispatch_and_reply
  3 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher incoming.message))
  4 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 177, in _dispatch
  5 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
  6 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo/messaging/rpc/dispatcher.py", line 123, in _do_dispatch
  7 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
  8 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/exception.py", line 88, in wrapped
  9 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher payload)
 10 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/openstack/common/excutils.py", line 82, in __exit__
 11 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
 12 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/exception.py", line 71, in wrapped
 13 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return f(self, context, *args, **kw)
 14 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 296, in decorated_function
 15 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher pass
 16 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/openstack/common/excutils.py", line 82, in __exit__
 17 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
 18 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 282, in decorated_function
 19 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return function(self, context, *args, **kwargs)
 20 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 346, in decorated_function
 21 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return function(self, context, *args, **kwargs)
 22 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 324, in decorated_function
 23 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher kwargs['instance'], e, sys.exc_info())
 24 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/openstack/common/excutils.py", line 82, in __exit__
 25 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
 26 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 312, in decorated_function
 27 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return function(self, context, *args, **kwargs)
 28 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 2431, in stop_instance
 29 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher do_stop_instance()
 30 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/openstack/common/lockutils.py", line 325, in inner
 31 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher return f(*args, **kwargs)
 32 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 2422, in do_stop_instance
 33 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher self._power_off_instance(context, instance, clean_shutdown)
 34 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 2222, in _power_off_instance
 35 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher self.driver.power_off(instance, timeout, retry_interval)
 36 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher TypeError: power_off() takes exactly 2 arguments (4 given)
 37 2014-08-21 12:43:28.603 TRACE oslo.messaging.rpc.dispatcher

[Adam Gandelman (gandelman-a)]

https://review.openstack.org/#/c/68942/32 introduced some new function parameters that need to be accounted for in the ironic driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116093

[Adam Gandelman (gandelman-a)]

Marking this as High as it totally semi-silently breaks the 'nova stop' call and causes various tempest failures.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116093
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=080890efa51b206617d2710d9ac89a082edb4942
Submitter: Jenkins
Branch: master

commit 080890efa51b206617d2710d9ac89a082edb4942
Author: Adam Gandelman <email address hidden>
Date: Thu Aug 21 13:14:30 2014 -0700

    Update nova driver's power_off() parameters

    The nova driver's power_off() function received two new parameters
    in commit c07ed15415c0ec3c5862f437f440632eff1e94df (nova). The
    in-tree drivers were all updated. This updates the Ironic driver
    and avoids a traceback during power off.

    Change-Id: I0cbe7d954f0bcc16f7249304321a08d457eaba52
    Closes-bug: #1359943