ERROR state from power drivers should be checked

[Yuriy Zveryanskyy]

Power drivers (ipmitool, ipminative for example) can return ERROR state. This error is not checked in manager._do_sync_power_state, conductor.utils.node_power_action. Because ERROR state from driver can be
valid unknown state, it is up to the caller to decide what to do.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116876

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/117499

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116876
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=134c2e8b0f8401db0ff768224bb58084cf1c3169
Submitter: Jenkins
Branch: master

commit 134c2e8b0f8401db0ff768224bb58084cf1c3169
Author: Yuriy Zveryanskyy <email address hidden>
Date: Tue Aug 26 14:59:01 2014 +0300

    Check ERROR state from driver in _do_sync_power_state

    Power driver can returns ERROR state. This error is not checked
    in manager._do_sync_power_state.

    Partial-Bug: #1358816
    Change-Id: I0672da6159252a1a2901f31ae11e2b29bc6147ef

[Lucas Alvares Gomes (lucasagomes)]

tagging to rc1 after talking to the person assigned to it on IRC:

<lucasagomes> yuriyz, should we tag bug 1358816 to RC1?
<yuriyz> lucasagomes, IMO we should

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/117499
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=37b71282a918e9ec788810ed1abd29498cff12a1
Submitter: Jenkins
Branch: master

commit 37b71282a918e9ec788810ed1abd29498cff12a1
Author: Yuriy Zveryanskyy <email address hidden>
Date: Thu Aug 28 15:10:09 2014 +0300

    Log ERROR power state in node_power_action()

    Power driver can returns ERROR state. Log this error and do not
    break requested action (this can be unknown valid state).

    Partial-Bug: #1358816
    Change-Id: I9b26440671cb44b58016dfd796adbd8fedd483ae

[Dmitry Tantsur (divius)]

This bug seems fixed to me, please feel free to reopen, if you have something else to fix.