Code is duplicated in agent and pxe drivers

Bug #1350594 reported by Jim Rollenhagen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Sam Betts

Bug Description

Duplicated functions between the two drivers:

* _fetch_images
* _cache_tftp_images

Tags: agent pxe
Revision history for this message
Dmitry Tantsur (divius) wrote :

Please note the ongoing work on unifying cleanup: https://review.openstack.org/#/c/107996/

Changed in ironic:
status: New → Triaged
tags: added: agent pxe
Changed in ironic:
importance: Undecided → Low
Revision history for this message
Dmitry Tantsur (divius) wrote :

Only _fetch_images remained after landing https://review.openstack.org/#/c/110560/

description: updated
Sam Betts (sambetts)
Changed in ironic:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131405

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/131405
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=68c6f1f8a1b87967572c50e6b55161538db1be2c
Submitter: Jenkins
Branch: master

commit 68c6f1f8a1b87967572c50e6b55161538db1be2c
Author: Sam Betts <email address hidden>
Date: Tue Oct 28 11:49:14 2014 +0000

    Remove duplicated _fetch_images function

    This patch removes the _fetch_images function from the agent driver and
    changes the driver to use the identical function found in deploy_utils.py

    Change-Id: Ic206258f65a88c0f7557b405c7de425cfd01900f
    Closes-Bug: 1350594

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.