IPA attempts to secure erase raid devices

[Jay Faulkner]

Relevant logs:
Jul 18 07:41:25 core576756 systemd-nspawn[2870]: " execute /usr/local/lib/python2.7/dist-packages/ironic_python_agent/utils.py:38
Jul 18 07:41:25 core576756 systemd-nspawn[2870]: 2014-07-18 07:41:25.739 2873 DEBUG ironic_python_agent.utils [-] Command stderr is: "" execute /usr/local/lib/python2.7/dist-packages/ironic_python_agent/utils.py:39
Jul 18 07:41:25 core576756 systemd-nspawn[2870]: 2014-07-18 07:41:25.740 2873 DEBUG ironic_python_agent.openstack.common.processutils [-] Running cmd (subprocess): hdparm -I /dev/md127 execute /usr/local/lib/python2.7/dist-packages/ironic_python_agent/openstack/common/processutils.py:155
Jul 18 07:41:25 core576756 systemd-nspawn[2870]: 2014-07-18 07:41:25.743 2873 DEBUG ironic_python_agent.openstack.common.processutils [-] Result was 0 execute /usr/local/lib/python2.7/dist-packages/ironic_python_agent/openstack/common/processutils.py:188
Jul 18 07:41:25 core576756 systemd-nspawn[2870]: 2014-07-18 07:41:25.744 2873 DEBUG ironic_python_agent.utils [-] Execution completed, command line is "hdparm -I /dev/md127" execute /usr/local/lib/python2.7/dist-packages/ironic_python_agent/utils.py:37

IPA should only find physical block devices to secure erase. Not raid devices.

[Jay Faulkner (jason-oldos)]

https://review.openstack.org/#/c/108040 is a proposed fix for this. I'd prefer we resolve this entire class of bugs by using `lsblk` instead of `blockdev --report`, so we're working on updating the patch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108040
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=83782018f73266d52e5c3fab6e82f3d3257fb94d
Submitter: Jenkins
Branch: master

commit 83782018f73266d52e5c3fab6e82f3d3257fb94d
Author: Josh Gachnang <email address hidden>
Date: Fri Jul 18 08:13:12 2014 -0700

    Improve Disk Detection

    The previous implementation of list_block_devices used blockdev,
    which would list partitions, software RAID and other devices as block devices.
    By switching to lsblk, the agent can filter down to only physical block
    devices, which is all the agent cares about for any of its operations.

    This change adds two new fields to the BlockDevice class: model, a string of
    the block devices reported model, and rotational, a boolean representing a
    spinning disk (True) or a solid state disk (False). This data can be useful
    for vendor hardware managers.

    Change-Id: I385c3bb378c2c49385bca14a1d7efa074933becf
    Closes-Bug: 1344351