No notice given when db migrations are not run due to missing engine
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Ironic |
Fix Released
|
Low
|
aeva black | |
| OpenStack Compute (nova) |
Low
|
Unassigned | ||
| oslo-incubator |
High
|
Ilya Pekelny |
Bug Description
When the unit test suite is run and there is no backend configured for testing migrations, the test passes rather than indicating that it was skipped. This has caused developers to assume the test passed when, in fact, it never ran.
To run the migration tests, one must configure a storage backend in tests/db/
In the absence of this, TestMigrations.
Changed in ironic: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in ironic: | |
assignee: | nobody → Devananda van der Veen (devananda) |
status: | Triaged → In Progress |
tags: | added: db |
Changed in oslo: | |
importance: | Undecided → High |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f9c7e4344a49a37
Author: Devananda van der Veen <email address hidden>
Date: Fri Jun 6 12:42:00 2014 -0700
Skip migrations test_walk_versions instead of pass
When there is no db engine configured for the migration tests,
the test_walk_versions test was passing, rather than skipping,
because it contained a for-loop and no check for the length of the
sequence being iterated over.
This patch checks the length of the configured engines and
properly skips the test when there are no engines.
Change-Id: I8a5c0a66f65a99
Closes-bug: #1327397
Changed in ironic: | |
status: | In Progress → Fix Committed |
Changed in ironic: | |
milestone: | none → juno-1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 08201764d1500a4
Author: Joe Gordon <email address hidden>
Date: Fri Jun 13 14:46:37 2014 -0700
Skip migrations test_walk_versions instead of pass
When there is no db engine configured for the migration tests,
the test_walk_versions test was passing, rather than skipping,
because it contained a for-loop and no check for the length of the
sequence being iterated over.
This patch checks the length of the configured engines and
properly skips the test when there are no engines.
Change-Id: I4078655f01638c
Co-Authored-By: Devananda van der Veen<email address hidden>
Closes-bug: #1327397
Changed in nova: | |
status: | Confirmed → Fix Committed |
Changed in oslo: | |
assignee: | nobody → Ilya Pekelny (i159) |
status: | New → In Progress |
Doug Hellmann (doug-hellmann) wrote : | #4 |
See also https:/
haruka tanizawa (h-tanizawa) wrote : | #5 |
I have no permission to change nova's assignee:
Unassigned -> Joe Gordon
Thanks.
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit c34c32e09ed1f17
Author: Ilya Pekelny <email address hidden>
Date: Tue May 13 14:44:54 2014 +0300
Opportunistic migration tests
Migrations should be tested with real database backends. For this goal
intended number of base test cases which used in current implementation.
Previously there were two ways to run migration tests: using
opportunistic test cases (default way we've been using on CI) and
by using database connection strings, specified in test_migrations
for every particular database test case. For the sake of simplicity and
consistency we are moving to using of opportunistic db test cases here.
With this change we are free from locking, so we don't need `lockfile`
anymore.
Closes-Bug: #1327397
Closes-Bug: #1328997
Change-Id: I92b1dcd830c475
Changed in oslo: | |
status: | In Progress → Fix Committed |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit ffd83dc3af17060
Author: Victor Sergeyev <email address hidden>
Date: Tue Jul 15 12:41:34 2014 +0300
Use opportunistic approach for migration testing
Refactored migration tests due to use OpportunisticTe
unused code and ``test_
This change allows tests use database ``openstack_
for connection to the database backend. The main feature of this
approach is - for each migration test will be created new database
with random name. This will avoid migration tests of race conditions
and reduce tests intersection.
``test_
database for migration test, so we no longer need test database credentials.
Closes-Bug: #1327397
Closes-Bug: #1328997
Change-Id: I95ad140ba5f483
Changed in nova: | |
milestone: | none → juno-2 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | none → juno-2 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | juno-2 → 2014.2 |
Changed in ironic: | |
milestone: | juno-1 → 2014.2 |
Fix proposed to branch: master /review. openstack. org/98504
Review: https:/