Huge test case for Ironic Nova driver should be split

[Dmitry Tantsur]

Currently, tests for Ironic Nova driver consist of one giant test case. That is not convenient from mocking point of view, as it requires different set of mocks to be places on every method. It is also hard to reason about. Splitting into several meaningful test cases will allow to have mock decorators mostly at class-levels, which will lead to less cluttered code. It will also simplify review for Nova folks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106933

[Dmitry Tantsur (divius)]

Should be fixed in Nova now - driver is no longer in Ironic tree

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lucas Alvares Gomes (<email address hidden>) on branch: master
Review: https://review.openstack.org/106933
Reason: Thanks for the patch! Unfortunately the changes doesn't belongs to Ironic anymore, the Ironic Nova driver was finally moved to the Nova tree (yay). Please resubmit it to Nova.

Thanks again!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135185

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135230

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ankur Gupta (<email address hidden>) on branch: master
Review: https://review.openstack.org/135185
Reason: Creating new review-
https://review.openstack.org/#/c/135230/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/135554

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: master
Review: https://review.openstack.org/135554
Reason: This change appears to have been uploaded in error. https://ask.openstack.org/en/question/53715

[Jeremy Stanley (fungi)]

The current proposed nova patch for this is https://review.openstack.org/135230

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/135230
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Fix proposed is currently in progress - https://review.openstack.org/135230