Improve docstrings from previous documentation patch

Bug #1324169 reported by Matt Wagner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Ruby Loo

Bug Description

I submitted https://review.openstack.org/#/c/83577/ a while back. It was a misguided attempt to add documenation for configuration options.

We decided that it made much more sense to just make the text in the sample configuration file more helpful, which is basically what I did in that patch -- except I moved it to a static file instead.

It'd be valuable to move the descriptions from that file to the docstrings that generate the sample config file, and to also look into the "FIXME" questions I had there.

Changed in ironic:
assignee: nobody → Matt Wagner (matt-wagner)
Ruby Loo (rloo)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
Changed in ironic:
importance: Low → Wishlist
Revision history for this message
Matt Wagner (matt-wagner) wrote :

Unassigning myself for now, though I will tackle this if no one else does. If someone gets to it before me, feel free.

Changed in ironic:
assignee: Matt Wagner (matt-wagner) → nobody
Jon Grimm (jgrimm)
Changed in ironic:
assignee: nobody → Jon Grimm (jgrimm)
Jon Grimm (jgrimm)
Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130642

Changed in ironic:
assignee: Jon Grimm (jgrimm) → Devananda van der Veen (devananda)
Revision history for this message
Dmitry Tantsur (divius) wrote :

Hi all! Judging by the (seemingly abandoned) patch I believe after numerous changes to our config this bug is no longer valid. Please reopen with explanation if you feel otherwise.

Changed in ironic:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/174164

Changed in ironic:
assignee: Devananda van der Veen (devananda) → Ruby Loo (rloo)
status: Invalid → In Progress
Revision history for this message
Ruby Loo (rloo) wrote :

This patch: https://review.openstack.org/174164 includes changes based on the documentation from https://review.openstack.org/#/c/83577/ and from the previous patch above https://review.openstack.org/130642.

(I had contacted Jon Grimm in March, to see if he was going to finish 130642 and he said that if he didn't do it, I was welcome to finish it. I'm not sure now, why I created a new patch instead of finishing his. Maybe because I wanted to start from scratch with the original documentation.)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ruby Loo (<email address hidden>) on branch: master
Review: https://review.openstack.org/130642
Reason: Am abandoning this patch because https://review.openstack.org/174164 includes these changes.

Jon, I know we discussed that I could finish this patch, but I ended up doing a separate patch. Hope you don't mind. Not sure why now, although maybe it was cuz this needed to be rebased and I wanted to start from scratch, making changes as I looked through Matt's original document.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/174164
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5b40b113333734034669c1de0d0eb758f3393797
Submitter: Jenkins
Branch: master

commit 5b40b113333734034669c1de0d0eb758f3393797
Author: Ruby Loo <email address hidden>
Date: Thu Apr 16 00:22:26 2015 +0000

    Update some config option's help strings

    Some config option's help strings are updated based on the
    documentation/feedback in a previous patch that attempted
    to document the config options, but we decided that it would
    be better to update the help in the configs themselves:
        https://review.openstack.org/#/c/83577/

    Change-Id: Ied2a4d69b735e919ab0597ac8d53df5dcd2a0ff6
    Closes-Bug: 1324169

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
milestone: none → 4.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.