Advertise Host for ironic-python-agent has a bad default

[Jay Faulkner]

Here: https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/cmd/agent.py#L57 ironic-python-agent sets the default advertise host to 0.0.0.0 -- this will never work and is a bad default.

It should be replaced with a more logical default -- such as the IP on the interface that the default gateway goes out of, or the IP on the first interface, but basically anything that would have a chance of being valid is better than the existing behavior.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96980

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96980
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=b4f1a0b2d32fc21ede9460540128a2129dc733ea
Submitter: Jenkins
Branch: master

commit b4f1a0b2d32fc21ede9460540128a2129dc733ea
Author: Ellen Hui <email address hidden>
Date: Fri May 30 23:55:34 2014 +0000

    Tries to advertise valid default IP

    During the first heartbeat, the heartbeater asks the agent to check
    its advertised address; if the advertised IP is still the default
    (None), the agent tries to replace it with the IP of the first network
    interface it finds. If it fails to find either a network interface or
    an IP address, the agent raises an exception.

    Change-Id: I6d435d39e99ed0ff5c8b4883b6aa0b356f6cb4ae
    Closes-Bug: #1309110