Deprecate command_name argument
Bug #1308021 reported by
Vladimir Kozhukalov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Fix Released
|
Undecided
|
Russell Haering |
Bug Description
We have unused command_name argument in all extension methods. Let's remove it.
Changed in ironic: | |
assignee: | nobody → Vladimir Kozhukalov (kozhukalov) |
Changed in ironic: | |
assignee: | Vladimir Kozhukalov (kozhukalov) → Russell Haering (russellhaering) |
status: | New → In Progress |
Changed in ironic: | |
milestone: | none → juno-1 |
status: | Fix Committed → Fix Released |
Changed in ironic: | |
milestone: | juno-1 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/87147 /git.openstack. org/cgit/ openstack/ ironic- python- agent/commit/ ?id=bf746732268 c073b4749df1a1e 35a762d9f8a816
Committed: https:/
Submitter: Jenkins
Branch: master
commit bf746732268c073 b4749df1a1e35a7 62d9f8a816
Author: Russell Haering <email address hidden>
Date: Sun Apr 13 17:45:18 2014 -0700
Decorated commands no longer take command_name
Prior to the (sync|async) _command decorators, extension methods had to
construct command results themselves, which required that they have
the name of the command being executed.
When the async_command decorator was introduced, we wanted to maintain
the current command interface, so that a command could be made
asynchronous simply by adding the decorator.
The introduction of the sync_command decorator allows us to satisfy
this objective, without requiring decorated methods to accept a
command_name. This patch modifies both decorators to no longer pass
the command_name argument, and modifies existing command methods not
to expect one.
Closes-Bug: #1308021 dcb79c6f4d2b10c 1e5e8c0cca3
Change-Id: I1b33bb7519588c