test should use node.id instead of '123'

Bug #1306214 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Tushar Kalra

Bug Description

In ironic/tests/drivers/test_utils.py, test_get_node_mac_addresses() uses node_id='123'. This value is actually from self.node.id, and the code would be easier to understand and more maintainable if we used self.node.id. (Eg, what if that id value was changed in the future.)

Bonus points - see if this hardcoding is done in other tests and fix as well.

This is a follow-up, from https://review.openstack.org/#/c/78787/3/ironic/tests/drivers/test_utils.py.

Ruby Loo (rloo)
affects: python-ironicclient → ironic
Tushar Kalra (tkay)
Changed in ironic:
assignee: nobody → Tushar Kalra (tkay)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88433

Changed in ironic:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/88433
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b79aeb58a9cef67b471863d4940f33bf4cd044d5
Submitter: Jenkins
Branch: master

commit b79aeb58a9cef67b471863d4940f33bf4cd044d5
Author: Tushar Kalra <email address hidden>
Date: Thu Apr 17 13:45:53 2014 -0700

    Remove hardcoded node id value

    Change-Id: I9e4e74ce3a41e1cd3dd4e0d9ff1d1bde0656527f
    Closes-Bug: 1306214

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.