Ironic

nova.virt.driver:node_is_available is not overridden

Bug #1299288 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Pablo Fernando Cargnelutti
Ironic 2014.2 "juno"

Bug Description

The default implementation of nova.virt.driver:node_is_available() is exceedingly inefficient (it calls get_host_stats which fetches the complete node list from Ironic). It should be overridden in the nova.virt.ironic.driver class with a single GET to ironic's API.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
tags: added: low-hanging-fruit
Changed in ironic:
milestone: none → juno-1
Pablo Fernando Cargnelutti (pablo-fernando-cargnelutti)
Changed in ironic:
assignee: nobody → Pablo Fernando Cargnelutti (pablo-fernando-cargnelutti)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84214

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/84214
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=828060ff79f3f96f143331e3054f66685e5f562d
Submitter: Jenkins
Branch: master

commit 828060ff79f3f96f143331e3054f66685e5f562d
Author: Pablo Fernando Cargnelutti <email address hidden>
Date: Mon Mar 31 15:56:33 2014 -0300

    Overwriting node_is_available in IronicDriver

    Overwriting node_is_available so it call to
    node.get from the ironic client.

    Change-Id: If27048342349c6eb87291416d82f719001db6dac
    Closes-Bug: #1299288

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.