translated .po files do not contain any translation text

Bug #1298645 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
aeva black
openstack i18n
Fix Released
Undecided
Unassigned

Bug Description

The translation team has been working on several translations of Ironic's error messages. General status can be seen here:
  https://www.transifex.com/projects/p/ironic/
and specific languages translated strings can be seen eg. here:
  https://www.transifex.com/projects/p/ironic/viewstrings/#pt_BR/ironic-translations

Jenkins translation jobs *should* be posting the translated strings to our tree. Ironic has been receiving regular git reviews from the jenkins translation job, eg:
  https://review.openstack.org/#/c/82993/

However they have not actually contained any translated "msgstr" values. The job's logs shows errors uploading to transifex, eg:
  http://logs.openstack.org/periodic/ironic-propose-translation-update/6aed392/console.html#_2014-03-27_06_07_06_640

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Critical
milestone: none → icehouse-rc1
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/83935

Revision history for this message
aeva black (tenbrae) wrote :

python script to clean the cruft out of the .po files, in case it's useful to anyone else:

  http://paste.openstack.org/show/74602/

Changed in ironic:
assignee: nobody → Devananda van der Veen (devananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/83935
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ea5488e24a66b2de09fd70a5a84e52d22c547a4c
Submitter: Jenkins
Branch: master

commit ea5488e24a66b2de09fd70a5a84e52d22c547a4c
Author: Devananda van der Veen <email address hidden>
Date: Fri Mar 28 16:46:00 2014 -0700

    Remove obsolete po entries - they break translation jobs

    The ironic-propose-translation-update job has been failing to update
    from transifex because our .po files contain duplicates of obsolete
    entries which were causing errors.

    Change-Id: I41a056cbe10096c07e7682d8d79ff8f8c58ad3e2
    Related-bug: #1298645

Revision history for this message
aeva black (tenbrae) wrote :

That fix did not solve the problem after all, but we've looked further into it and it seems to be that "tx pull -a" is skipping .po files whose local file timestamps are newer than the remote timestamps.

Run locally with --debug yields this:

Pulling languages for: set(['pt_BR'])
Pulling translations for resource ironic.ironic-translations (source: ironic/locale/ironic.pot)
Using file ironic/locale/pt_BR/LC_MESSAGES/ironic.po
Remote time is 1395996600.0 and local 1396317161.0
Local is newer than remote for lang pt_BR
Skipping 'pt_BR' translation (file: ironic/locale/pt_BR/LC_MESSAGES/ironic.po).

Running "pull --debug --force -a" actually pulls properly, after which, hopefully, the rest of the job will be able to complete.

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/84210

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84259

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/84259
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9f04dd15081181e1758c4bfde922d49956850fe3
Submitter: Jenkins
Branch: master

commit 9f04dd15081181e1758c4bfde922d49956850fe3
Author: Devananda van der Veen <email address hidden>
Date: Mon Mar 31 14:15:05 2014 -0700

    Manually update all translated strings

    Git has been updating the localization (.po) files, and as a result, the
    'tx pull -a' command, run by jenkins in the periodic translation jobs,
    has been failing to pull new strings from transifex.

    This patch is a manual pull from transifex to update all the strings
    for inclusion in Icehouse RC1.

    A longer-term fix has been proposed to -infra here:
      https://review.openstack.org/#/c/84191/

    Change-Id: I9fba04d2369b36fe4902e388774506cd8e6ea377
    Closes-bug: #1298645

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (master)

Reviewed: https://review.openstack.org/84210
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5d363dc9c449a60f5a9fd5f06e8b541803dd17f5
Submitter: Jenkins
Branch: master

commit 5d363dc9c449a60f5a9fd5f06e8b541803dd17f5
Author: Andreas Jaeger <email address hidden>
Date: Mon Mar 31 20:42:46 2014 +0200

    Check that all po/pot files are valid

    Perform minimal checks on po and pot files so that no broken files can
    get imported.

    Change-Id: I328fc11c688c16737ae88984e4778483ce5db5ab
    Co-Authored-By: Clark Boylan <email address hidden>
    Related-Bug: #1298645

Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-rc1 → 2014.1
Changed in openstack-i18n:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers