Unit test coverage for _do_sync_power_state should be improved

Bug #1297404 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Michael Davies

Bug Description

_do_sync_power_state() and the handling around power_state_sync_max_retries should have better unit test coverage, particularly around exception handling.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
tags: added: low-hanging-fruit
Rohan (kanaderohan)
Changed in ironic:
assignee: nobody → Rohan (kanaderohan)
Revision history for this message
Dmitry Tantsur (divius) wrote :

Hi! Per global bugs clean-up, we're unassigning bugs that are without patch and other visible progress for more than 7 days. Please feel free to reassign yourself, set status to In Progress and leave some status comment, if this is wrong. Thank you for understanding!

Changed in ironic:
assignee: Rohan (kanaderohan) → nobody
Michael Davies (mrda)
Changed in ironic:
assignee: nobody → Michael Davies (mrda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/99271

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/99271
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ef83e3a6fb6901efbc3156ea6e33320ec9f6d801
Submitter: Jenkins
Branch: master

commit ef83e3a6fb6901efbc3156ea6e33320ec9f6d801
Author: Michael Davies <email address hidden>
Date: Sat Jun 7 00:46:59 2014 +0930

    Improving unit tests for _do_sync_power_state

    Improve the unit tets coverage, and tightening up existing
    tests surrounding the _do_sync_power_state method.

    Change-Id: I9fd4c4c42936fcf8fc4f36bf35b6e691c495b8b0
    Closes-bug: #1297404

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.