change_node_power_state inconsistent; validation in async part

[Ruby Loo]

Now that we are changing ironic.conductor.manager.ConductorManager to use worker threads, validations are being done in the synchronous part. (Eg, .vendor_passthru(), .do_node_deploy()). However, .change_node_power_state() is doing the validation in the async part. This is inconsistent and I think it may cause confusion to the users.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84374
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=66dad963c29525c42557957bdae0da01add65131
Submitter: Jenkins
Branch: master

commit 66dad963c29525c42557957bdae0da01add65131
Author: Michael Davies <email address hidden>
Date: Tue Apr 1 17:50:42 2014 +1030

    Handling validation in conductor consistently

    Change where we do validation in change_node_power_state to follow
    where we do it for do_node_deploy and vendor_passthrough. That
    is, we perform validation synchronously before we spawn off a
    thread to perform the longer running action.

    Change-Id: Ic1f791bb5ef49c033e4baff8d3f6900091dbf332
    Closes-bug: #1294676