utils.mkfs() does not check whether formatting to the specified filesystem

[Roman Prykhodchenko]

Currently there's no check whether mkfs is able to format the partition to the specified filesystem. Specifying an unsupported one will lead to a generic exception.

[Roman Prykhodchenko (romcheg)]

The major problem is that the only reliable way to fix this bug is to parse the error message returned by mkfs. That requires specifying LANG=C environment variable for running mkfs. However, passing environment variables is not supported in oslo yet.

This patch https://review.openstack.org/#/c/86021/ allows passing environment variables to processutils.execute() so we should wait until it gets merged.

[Dmitry Tantsur (divius)]

Hi Roman! Are you still working on this patch? Patch you mention in your comment got landed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/98102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98102
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0d0c31af7a992fbb46e41076240a000923e81a83
Submitter: Jenkins
Branch: master

commit 0d0c31af7a992fbb46e41076240a000923e81a83
Author: Mikhail Durnosvistov <email address hidden>
Date: Thu Jun 5 15:50:17 2014 +0300

    Check whether specified FS is supported

    Added to `utils.mkfs()` checking that not supported file systems.

    Change-Id: If3cff21b8b4ffb969e7bcfc0d9769a36f23061dd
    Closes-Bug: #1286244