Ironic will poke the node continuously, if it fails to change power state

[Roman Prykhodchenko]

Since power state is being force-set to the node if it mismatches the DB record the node will be poked every time a sync_power_state periodic task is running.

This can be fixed by specifying the maximum number of times Ironic should try force-setting the power state.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/77420
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=65098bcf6576526200a5c946c8aa12352d8e33d3
Submitter: Jenkins
Branch: master

commit 65098bcf6576526200a5c946c8aa12352d8e33d3
Author: Rohan Kanade <email address hidden>
Date: Sun Mar 2 11:27:44 2014 +0100

    Adds max retry limit to sync_power_state task

    * sync_power_state periodic task tries to set node's actual power state.
      In case of failure to sync power state, Ironic will keep trying to
      sync power state, Hence introduce a max retry per node
      sync power state limit
    * Set Node's DB power state as the actual Node power state if max retries
      exceeded
    * Set the Node's last_error msg after max retries exceed and set the
      node in maintainence mode

    Change-Id: Idbd3afab746f81b9097e97afb1d12a81686a4564
    Closes-Bug: #1285806