config generator returns wrong value for CONF.host parameter

[Viktor Serhieiev]

CONF.host parameter get it's default value as socket.getfqdn(), see [1], but in config generator we check, if default value of CONF.host equal with socket.gethostname(). See [2], [3].

Python documentation says, that " gethostname() doesn’t always return the fully qualified domain name". See [4]. So it caused pep-8 failures as on patch set 1 in patches [5] and [6].

[1] https://github.com/openstack/ironic/blob/master/ironic/common/service.py#L36
[2] https://github.com/openstack/ironic/blob/master/ironic/openstack/common/config/generator.py#L205
[3] https://github.com/openstack/oslo-incubator/blob/master/openstack/common/config/generator.py#L229
[4] http://docs.python.org/2/library/socket.html#socket.gethostname
[5] https://review.openstack.org/#/c/74760/
[6] https://review.openstack.org/#/c/74781/

[Yuriy Zveryanskyy (yzveryanskyy)]

I think this is an Oslo bug.

Possible fix in Oslo code

elif value in (socket.gethostname(), socket.getfqdn()) and 'host' in name:

here

https://github.com/openstack/oslo-incubator/blob/master/openstack/common/config/generator.py#L229

[Viktor Serhieiev (vsergeyev)]

I looked at some other projects, and found, that they use socket.gethostname() for host default value.
Anyway, let's ask Oslo folks opinion.

[Ben Nemec (bnemec)]

I would be fine with adding getfqdn to that check. It fits the behavior we're expecting there, and I don't think it's unreasonable for a project to want the fqdn as the default value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75349
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=1a6dfb956d1b4b8a912b148de299a9d94cb46bd3
Submitter: Jenkins
Branch: master

commit 1a6dfb956d1b4b8a912b148de299a9d94cb46bd3
Author: Yuriy Zveryanskyy <email address hidden>
Date: Fri Feb 21 10:59:43 2014 +0200

    Sanitize FQDN in config generator

    Some projects (Ironic for example) may to use socket.getfqdn()
    as default for 'host' config parameter. It can cause an error
    in check_uptodate config test.

    Closes-Bug: #1282481
    Change-Id: I322b1f472babd3894a9a27269c03d5aace26d650

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74760
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1fd5b44425646ddcc8801e57f65a1974f30e4330
Submitter: Jenkins
Branch: master

commit 1fd5b44425646ddcc8801e57f65a1974f30e4330
Author: Victor Sergeyev <email address hidden>
Date: Tue Feb 18 16:54:55 2014 +0200

    Sync common config module from Oslo

    List of changes

    1a6dfb9 Sanitize FQDN in config generator
    e839886 Config generator fails with lazy messages
    763eedf Fix DictOpt support in config sample generator
    e3dddd7 generator: use EXTRA_* env vars in the bash script
    e8e636c generator: add an EXTRA_LIBRARIES env variable
    5dce17b Use entry points to discover options in libraries
    dd9aa2b Remove unused variables
    ad17a69 Fix filter() usage due to python 3 compability
    7c18261 Temporary workaround for config generator
    4b3e32b Sort the output of config/generator.py by group name
    12bcdb7 Remove vim header
    806272e Improve error reporting on import failures
    6cd1c33 Clean up extra modules code

    Updated ironic.conf.sample using new config generator.

    Closes-Bug: #1282481
    Change-Id: Ice3e527589bbf0e881d21f55229264513ea445d2