Old value in 'updated_at' field returned after resource was changed

[Yuriy Zveryanskyy]

yura@test-0:~$ ironic node-update 4f7a91d9-cc4e-4cd4-90e4-4648fb2519ae add extra/foo=baz
+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| chassis_uuid | None |
| created_at | 2014-02-18T15:52:20+00:00 |
| driver | fake |
| driver_info | {} |
| extra | {u'foo': u'baz'} | <- new values here
| instance_uuid | None |
| last_error | None |
| power_state | None |
| properties | {} |
| provision_state | None |
| reservation | None |
| target_power_state | None |
| target_provision_state | None |
| updated_at | None | <- wrong
| uuid | 4f7a91d9-cc4e-4cd4-90e4-4648fb2519ae |
+------------------------+--------------------------------------+

[Xurong Yang (idopra)]

Hi,Doing the test and this can't be reproducted in latest version.So I think it has been fixed.
ironic node-update bf205c84-c5ca-4bd6-adeb-ae7f1fb25f8a add extra/foo=baz
+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| chassis_uuid | 10592f8c-2e77-4f03-9542-e01cf37c4d4c |
| created_at | 2014-02-19T06:15:55+00:00 |
| driver | fake |
| driver_info | {} |
| extra | {u'foo': u'baz'} |
| instance_uuid | None |
| last_error | None |
| power_state | None |
| properties | {} |
| provision_state | None |
| reservation | None |
| target_power_state | None |
| target_provision_state | None |
| updated_at | 2014-02-19T06:18:15+00:00 | --ok
| uuid | bf205c84-c5ca-4bd6-adeb-ae7f1fb25f8a |
+------------------------+--------------------------------------+

[Yuriy Zveryanskyy (yzveryanskyy)]

Reproduced for port in latest version, and for chassis the same

yura@test-0:~$ ironic port-update 8397eede-d539-4f38-9e37-273060bd444a add extra/foo=bar
+------------+--------------------------------------+
| Property | Value |
+------------+--------------------------------------+
| address | aa:bb:cc:dd:ee:ff |
| created_at | 2014-02-19T09:51:42+00:00 |
| extra | {u'foo': u'bar'} |
| node_uuid | 02128c23-ddf4-4bea-a264-88569c0100e4 |
| updated_at | None |
| uuid | 8397eede-d539-4f38-9e37-273060bd444a |
+------------+--------------------------------------+

[Yuriy Zveryanskyy (yzveryanskyy)]

Hi Xurong Yang

your updated_at probably result of sync_power_states periodic task

I disable this task and reproduce for node again in latest version

yura@test-0:~$ ironic node-create -d fake
+--------------+--------------------------------------+
| Property | Value |
+--------------+--------------------------------------+
| chassis_uuid | None |
| driver | fake |
| driver_info | {} |
| extra | {} |
| properties | {} |
| uuid | 89bfb2cf-926f-4a36-96b2-939089d409ea |
+--------------+--------------------------------------+
yura@test-0:~$ ironic node-update 89bfb2cf-926f-4a36-96b2-939089d409ea add extra/foo=bar
+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| chassis_uuid | None |
| created_at | 2014-02-19T10:13:04+00:00 |
| driver | fake |
| driver_info | {} |
| extra | {u'foo': u'bar'} |
| instance_uuid | None |
| last_error | None |
| power_state | None |
| properties | {} |
| provision_state | None |
| reservation | None |
| target_power_state | None |
| target_provision_state | None |
| updated_at | None |
| uuid | 89bfb2cf-926f-4a36-96b2-939089d409ea |
+------------------------+--------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75430

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mike Durnosvistov (<email address hidden>) on branch: master
Review: https://review.openstack.org/75430

[Dmitry Tantsur (divius)]

Mikhail, is it correct to assume you no longer work on this bug?

[Mike Durnosvistov (glacierrdev)]

Dmitry, yep!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211849

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211849
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1f4680ab23f531d052935d1ee1b73972406e2653
Submitter: Jenkins
Branch: master

commit 1f4680ab23f531d052935d1ee1b73972406e2653
Author: Anusha Ramineni <email address hidden>
Date: Wed Aug 12 10:44:31 2015 +0530

    'updated_at' field shows old value after resource is saved

    chassis.save() and port.save() doesn't update object from db
    because of which 'updated_at' field for the object
    is not up-to-date after a save(). This commit fixes this issue.

    Partial-Bug:#1281638
    Change-Id: I98af458e95f7ed3c787a9bcf2550f89e471ccd21

[Dmitry Tantsur (divius)]

Hi! I see some fixes got merged, is it still a valid bug?

[Lucas Alvares Gomes (lucasagomes)]

I can confirm this is still valid for nodes but not for chassis or ports anymore: http://paste.openstack.org/show/576177/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/371605

[Yuriy Zveryanskyy (yzveryanskyy)]

Correct "updated_at" value is important for notifications payloads.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371605
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=065326c0f55a73c99706148f7bfbbec87ea863bc
Submitter: Jenkins
Branch: master

commit 065326c0f55a73c99706148f7bfbbec87ea863bc
Author: Kyrylo Romanenko <email address hidden>
Date: Fri Sep 16 18:00:43 2016 +0300

    'updated_at' field value after node is updated

    node.save() doesn't update object from db because 'updated_at'
    field for the node is not up-to-date after a save().

    Change-Id: I58076d71e5977dded3f5485f295b3235d467872d
    Partial-Bug: #1281638
    Co-Authored-By: Galyna Zholtkevych <email address hidden>

[Yuriy Zveryanskyy (yzveryanskyy)]

Problem mentioned in bug description fixed.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/452930

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452930
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=62c6377adf5c3400834b29667cbf5e29e0e8bde6
Submitter: Jenkins
Branch: master

commit 62c6377adf5c3400834b29667cbf5e29e0e8bde6
Author: Ruby Loo <email address hidden>
Date: Mon Apr 3 16:24:46 2017 -0400

    Node should reflect what was saved

    After a node is saved to the database, we weren't updating the
    Node object to reflect what was saved. This caused a problem
    where the node's update_at field was incorrect. It was fixed
    in 065326c0f55a73c99706148f7bfbbec87ea863bc by explicitly
    setting node.update_at. However, that doesn't address other
    node fields that may be out of sync.

    The more correct fix would be to do a similar thing that (most
    of) the other Objects do, which is for the node to update itself
    via ._from_db_object().

    Doing this revealed several incorrect tests and code in the conductor
    and agent where changes to the node's dictionaries were incorrectly
    being set and thus, not being saved. Those are fixed in this patch.

    Change-Id: Ia84cd60c1a4eabcc1ad0a756124c338fa9f644c8
    Closes-Bug: #1679297
    Related-Bug: #1281638