Insufficient INFO logging

Bug #1273856 reported by aeva black
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Won't Fix
Low
Unassigned

Bug Description

Ironic is not logging very much at the INFO level today, and it should be. This is primarily what operators will use to look for activity, before turning on debugging.

Some guidelines have been proposed across projects, and we should aim to follow them:
  https://wiki.openstack.org/wiki/LoggingStandards

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Medium
tags: added: low-hanging-fruit
aeva black (tenbrae)
Changed in ironic:
milestone: none → icehouse-3
Rohan (kanaderohan)
Changed in ironic:
assignee: nobody → Rohan (kanaderohan)
aeva black (tenbrae)
Changed in ironic:
assignee: Rohan (kanaderohan) → nobody
milestone: icehouse-3 → next
Revision history for this message
aeva black (tenbrae) wrote :

There has been some confusion / discussion on IRC as to when to log at what level. I believe the following summary by Lucas is worth referencing:

14:01:57 < lucasagomes> INFO for success, ERROR for failures, WARNING for failures that will be automatic retried or fallback
                        somehow, CRITICAL for errors that compromise the whole service and not an operation
14:02:01 < lucasagomes> and DEBUG for the rest

Ellen Hui (ellen-hui)
Changed in ironic:
assignee: nobody → Ellen Hui (ellen-hui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/99431

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/99495

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/99744

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/100360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ellen Hui (<email address hidden>) on branch: master
Review: https://review.openstack.org/100360
Reason: Doesn't seem that useful to log here.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ellen Hui (<email address hidden>) on branch: master
Review: https://review.openstack.org/99431
Reason: Abandoned in favor of https://review.openstack.org/#/c/99744/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/99744
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5a727ae886254014f8055d85dd0e3eaf37b816c2
Submitter: Jenkins
Branch: master

commit 5a727ae886254014f8055d85dd0e3eaf37b816c2
Author: Ellen Hui <email address hidden>
Date: Wed Jun 11 22:39:51 2014 +0000

    Add more INFO logging to ironic/conductor

    Change-Id: I9506852ed76cbb57f21403233809ca5f04b8046f
    Partial-Bug: #1273856

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/99495
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3ffa8b1c961e8392f0efed45d1d63e88f0549464
Submitter: Jenkins
Branch: master

commit 3ffa8b1c961e8392f0efed45d1d63e88f0549464
Author: Ellen Hui <email address hidden>
Date: Wed Jun 11 22:13:19 2014 +0000

    Add more INFO logging to ironic/common/service.py

    Change-Id: I60b0a33ce98f8b614a00af0c8cc5f27043bf022a
    Partial-Bug: #1273856

Revision history for this message
Dmitry Tantsur (divius) wrote :

Ellen Hui, hi! You've been assigned to this bug for a while already. Are you intending to do anything else about this bug? Could you give a status update or unassign yourself?

Dmitry Tantsur (divius)
Changed in ironic:
status: In Progress → Confirmed
assignee: Ellen Hui (ellen-hui) → nobody
Mark Soule (mlsoule)
Changed in ironic:
status: Confirmed → In Progress
assignee: nobody → Mark Soule (mlsoule)
Revision history for this message
aeva black (tenbrae) wrote :

Cross-project guidelines for LOG standardization have been agreed upon:
  http://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html

We should track this work against a blueprint instead of a bug. Bugs can have only one assignee, which is updated any time code is proposed, whereas a blueprint lets us track contributions from anyone that is working to improve the logging within Ironic.

Changed in ironic:
status: In Progress → Confirmed
importance: Medium → Low
assignee: Mark Soule (mlsoule) → nobody
milestone: next → none
Revision history for this message
aeva black (tenbrae) wrote :

Cross-project guidelines for LOG standardization have been agreed upon:
  http://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html

We should track this work against a blueprint instead of a bug. Bugs can have only one assignee, which is updated any time code is proposed, whereas a blueprint lets us track contributions from anyone that is working to improve the logging within Ironic.

I've filed the BP here: https://blueprints.launchpad.net/ironic/+spec/follow-logging-standard

Changed in ironic:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.