Updating a resource in the API doesn't allow UNSETTING an attribute

Bug #1220107 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

Partial PUT updates using pecan's objects is not good because it has wsme.Unset/None for all the non supplied fields, that would prevent clients to unset an attribute in the resource.

Of course you could clear the value of one attribute replacing it with an empty string or an empty dictionary, but that not setting it to NULL, so it's not ideal.

summary: - Updating a resource in the API doesn't allow us to UNSET an attribute
+ Updating a resource in the API doesn't allow UNSETTING an attribute
Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
status: New → In Progress
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/42690
Committed: http://github.com/openstack/ironic/commit/b96e297dbbbd47e69abbd1b5f468e1fc84b9ef6d
Submitter: Jenkins
Branch: master

commit b96e297dbbbd47e69abbd1b5f468e1fc84b9ef6d
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Aug 19 18:38:35 2013 +0100

    Updating resources with PATCH

    This patch enables clients to update the resources using the PATCH HTTP
    method. PATCH allows partial updates on the documents, reducing network
    and processing overhead. Attributes may be removed, replaced, or added
    in a single request.

    Closes-Bug: #1220107

    Change-Id: I8187f32b86f05fda58360cd3a51f07ae43742a3a

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.