stevedore no longer raises KeyError for missing plugin

Bug #1187209 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Low
aeva black

Bug Description

Stevedore issue #15 ( https://github.com/dreamhost/stevedore/issues/15 ) was recently closed, meaning that NodeManager._*_factory.map() will stop raising KeyErrors for missing drivers. We should be able to stop ignoring KeyErrors now:
  https://github.com/openstack/ironic/blob/master/ironic/manager/resource_manager.py#L69

There should probably also be a unit test to confirm the load continues to work without needing a try: block, even with missing plugins.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → Low
aeva black (tenbrae)
Changed in ironic:
assignee: nobody → Devananda van der Veen (devananda)
milestone: none → icehouse-2
aeva black (tenbrae)
Changed in ironic:
milestone: icehouse-2 → none
status: Triaged → Invalid
status: Invalid → Triaged
milestone: none → icehouse-2
Revision history for this message
aeva black (tenbrae) wrote :

Confirmed that as of stevedore 0.13, extension_manager continues to raise KeyError for plugins which are not found.

The linked github issue seems to be gone (or it moved and I don't know how to find it). Wrapping the stevedore call inside our driver_loader to catch KeyError has been working fine thus far, so I am going to close this bug and continue to use the existing approach.

Changed in ironic:
status: Triaged → Won't Fix
status: Won't Fix → Invalid
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-2 → none
Revision history for this message
Michael Davies (mrda) wrote :

I played with this one as well - can't reproduce the described stevedore behaviour, so marking this as invalid seems like a good idea.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.