can't disable file injection for bare metal

[Robert Collins]

For two reasons : a) until we have quantum-pxe done, it won't work, and b) file injection always happens.

One of the reasons to want to disable file injection is to work with hardware that gets a ethernet interface other than 'eth0' - e.g. if only eth1 is plugged in on the hardware, file injection with it's hardcoded parameters interferes with network bringup.

A workaround for homogeneous environments is to change the template to hardcode the interface name (s/iface.name/eth2/)

[aeva black (tenbrae)]

Marking as wishlist because 1) it's not something which *can* be fixed now, 2) supporting file injection isn't broken per-se. Making it optional would clearly be an improvement, though.

[Robert Collins (lifeless)]

Respectfully, I disagree on 2) - it's physically impossible to have two images with different vlan configs pre-set in /e/n/i today, you have to use a first-boot script to overwrite the file injection : thats unbreakme stuff, e.g. clearly broken.

[aeva black (tenbrae)]

My initial read of this was that using the injected network template was a sufficient work-around, but it seems that that is not the case. I also looked through the libvirt file injection code for comparison, and now agree that not being able to disable file injection in baremetal is a bug.

[Joe Gordon (jogo)]

As a first step we can make file injection optional and leave everything else the same. The next step is to optimize the image workflow for performance

[Joe Gordon (jogo)]

performance experiments:

For deploying two baremetal nodes. Two copies out of glance, convert to raw twice and two copies out.

* Given a given a local qcow2 do a qemu-image-convert directly to the iscsi partition
* convert and cache the RAW file and then DD that out

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47282

[Joe Gordon (jogo)]

Next step is to make sure baremetal.pxe doesn't pull done separate copies of the image if injection is disabled.

[aeva black (tenbrae)]

Joe, take a look at the PXE driver in Ironic. I believe Ghe already implemented the "don't download the same image twice" optimization there, so you may be able to port it to Nova if desired.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47282
Committed: http://github.com/openstack/nova/commit/cd9385633ffd50ebe8341d0d8a408a0b9fe85483
Submitter: Jenkins
Branch: master

commit cd9385633ffd50ebe8341d0d8a408a0b9fe85483
Author: Joe Gordon <email address hidden>
Date: Wed Sep 18 16:26:55 2013 -0700

    Add flag to make baremetal.pxe file injection optional

    File injection is slow and risky, So make it optional. File injection
    was used for getting networking configuration into the baremetal nodes,
    but neutron can do this now. File injection is also used for general
    file injection and password injection, but those should be optional as
    well.

    Change-Id: If59641952255e5aaf3767524e2b3c566eefe2b74
    Related-Bug: #1178103

[Robert Collins (lifeless)]

We can't close the task for this until dhcp-all-interfaces is functional : https://bugs.launchpad.net/diskimage-builder/+bug/1233577

[Roman Podoliaka (rpodolyaka)]

Can we close this now in TripleO?

[Joe Gordon (jogo)]

AFAIK yes

[aeva black (tenbrae)]

Marking as Invalid for Ironic -- file injection is not implemented in the PXE driver and thus doesn't need to be disabled.