issue with multipathd command

[Adam Rozman]

This command produces a non zero exit code and makes my IPA skip multipath devices when it is looking
for suitable root device (as expected, IPA thinks that there is no multipath support).
In reality there is multipath support and multipathd is already running, but contradicting
the comments, multipathd command does not exit with 0 when the daemon is already running.

The command: https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L216

My version of multipath-tools is 0.9.0

IPA error message (also reproduced manually):"process is already running failed to create pidfile"

I have removed the line in question in my tests, and everything started working without any issue, after the removal of the line in question IPA was able to function properly and the multipathd device was detected and the deployment succeeded.

After some discussion in the community IRC, we have arrived to the conclusion that the call to execute the multipathd command should be surrounded with an exception block.

I will work on the fix.

[Riccardo Pittau (rpittau)]

Thanks for reporting this, it looks indeed like a change in the multipath-tools package, so it seems it now exits with a non-zero code in case multipathd is already running, we're not sure if it's a regression or it's an intended change.
No matter what it is, having the command surrounded by an exception block is the favorite solution, thanks for proposing for a patch, looking forward to it!

[Adam Rozman (rozzix)]

I have started to work on this, expect a change soon.

[Jay Faulkner (jason-oldos)]

Fixed in https://opendev.org/openstack/ironic-python-agent/commit/13537db293543db9449f54d7b2a85e06b8c1e1bb