Proposal to implement basic auth support against simple http(s) disk image servers

Bug #2021947 reported by Adam Rozman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ironic-python-agent
Fix Released
Wishlist
Adam Rozman

Bug Description

Currently there is no support in IPA to use "basic auth" against http(s) servers that are hosting the disk images used during provisioning.

I would like to propose 2 new configuration variable for IPA that would be possible to supply via config file, cmd argument and kernel parameter. The 2 variable would be basicAuthUser and basicAuthPassword.

I am happy to work on this if the community agrees to accept the proposal.

Tags: rfe-approved
Adam Rozman (rozzix)
Changed in ironic-python-agent:
assignee: nobody → Adam Rozman (rozzix)
Adam Rozman (rozzix)
tags: added: rfe
Revision history for this message
Adam Rozman (rozzix) wrote :

I am happy to work on this upstream, In fact I need it right now so I am implementing it on a fork ATM and I would be happy to push it upstream.

Revision history for this message
Adam Rozman (rozzix) wrote :

I have pushed the first version of the implementation for both IPA and Ironic:
- https://review.opendev.org/c/openstack/ironic/+/890411
- https://review.opendev.org/c/openstack/ironic-python-agent/+/890272

Based on JayF's comment, I would need to change my approach of supplying the password for user image BAuth between Ironic and IPA, I have to modify the lookup process in both Ironic and IPA to support providing the credentials via the lookup API.

Changed in ironic-python-agent:
status: New → Triaged
importance: Undecided → Wishlist
tags: added: rfe-approved
removed: rfe
Revision history for this message
Adam Rozman (rozzix) wrote (last edit ):

I have reacted to all the reviews and answered all questions and rewrote the feature according to community requirements.
Please take a look.

summary: - Proposal to implement basich auth support against simple http(s) disk
+ Proposal to implement basic auth support against simple http(s) disk
image servers
Changed in ironic-python-agent:
status: Triaged → In Progress
tags: removed: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 24.0.0

This issue was fixed in the openstack/ironic 24.0.0 release.

Revision history for this message
Jay Faulkner (jason-oldos) wrote :

Thanks Adam!

Changed in ironic-python-agent:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.