IPA fails to record OSError failure with iscsi init

[Julia Kreger]

An exception catch in ironic_python_agent/extensions/iscsi.py for some reason has ProcessExecutionError from oslo, and OSError from python and expects identical data structures which do not exist.

OSError can be raised in cases, such as where a program just doesn't exist on disk.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/501386

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501386
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=308cddc1bb5d4ae8bb9f462d64ee6754f2d14d8d
Submitter: Zuul
Branch: master

commit 308cddc1bb5d4ae8bb9f462d64ee6754f2d14d8d
Author: Julia Kreger <email address hidden>
Date: Wed Sep 6 19:15:06 2017 +0000

    Fix OSError catch

    The _execute helper was catching OSError, except it
    was expecting the same attributes as ProcessExecutionError,
    which is incorrect.

    Added a separate catch and unit test to ensure that we
    at least properly catch and convert the error instead of
    raising an error about an attribute that does not exist.

    Change-Id: Id47715a5657478e4d9dd10ea7f360b1ededa27de
    Closes-Bug: #1715466

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic-python-agent 3.0.0 release.