LLDP discovery fails when I have NICs that aren't plugged in on my server

Bug #1665025 reported by Sam Betts on 2017-02-15
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Sam Betts

Bug Description

IPA creates a raw socket for these NICs which mark themselves as ready to read, so IPA tries to read data from them and gets a "Network is down" error. Processing of the network interfaces is handled sequentially which means if there is a NIC that fails processing before one of my NICs that are actually plugged in then it skips the rest of the NICs and so no LLDP data is received for any NIC after that.

Fix proposed to branch: master
Review: https://review.openstack.org/434385

Changed in ironic-python-agent:
assignee: nobody → Sam Betts (sambetts)
status: New → In Progress
Dmitry Tantsur (divius) on 2017-02-15
Changed in ironic-python-agent:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/434385
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=b536fbba616d958e58b110c8f86ea569f8834d7c
Submitter: Zuul
Branch: master

commit b536fbba616d958e58b110c8f86ea569f8834d7c
Author: Sam Betts <email address hidden>
Date: Wed Feb 15 16:31:33 2017 +0000

    [LLDP] Skip NICs that say they are ready but are unreadable.

    While listening for LLDP packets, if one of the sockets marks itself as
    ready to read then our code will try to read data from that socket, but
    if something goes wrong while reading that data then it causes IPA to
    raise out of the loop skipping any other of the other NICs which might
    have worked. This patch adds code to catch and LOG any exception that is
    raised while we are trying to read data from one of the sockets so that
    we can proceed to process all the NICs.

    Change-Id: I8546097f5ae23755a5fdb448902007a2d823b7bf
    Closes-Bug: #1665025

Changed in ironic-python-agent:
status: In Progress → Fix Released

This issue was fixed in the openstack/ironic-python-agent 3.1.0 release.

This issue was fixed in the openstack/ironic-python-agent 2.0.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers