LLDP discovery is not working when IPA is run on system with X710 network cards

Bug #1623659 reported by Tomasz Paszkowski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ironic-python-agent
Fix Released
Medium
Szymon Borkowski

Bug Description

Reason for that is that all i40e driver based network cards are running embedded LLDP agent. To disable that following command needs to be called:

for i in `ls /sys/kernel/debug/i40e` ; do
echo lldp stop > "${i}/command"
done

IMHO the best would be to execute this from IPA itself and not enable this in the CoreOS cloudconfig files.

Revision history for this message
Dmitry Tantsur (divius) wrote :

I think it's a good case for having a separate hardware manager: http://docs.openstack.org/developer/ironic-python-agent/#hardware-managers

Changed in ironic:
status: New → Triaged
affects: ironic → ironic-python-agent
Changed in ironic-python-agent:
importance: Undecided → Medium
Changed in ironic-python-agent:
assignee: nobody → Szymon Borkowski (szymon-borkowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/391836

Changed in ironic-python-agent:
status: Triaged → In Progress
Revision history for this message
Szymon Borkowski (szymon-borkowski) wrote :

I spoke with Tomasz about that bug and we were wrong -> each time the machine reboots, the embedded LLDP agent is run. Thus we need to stop it before the inspection starts. Hardware manager won't help, because its cleaning steps will be executed when the node is transitioned into 'available' state, so after the inspection.
I have an idea how to remake it: maybe just as a custom collector (like PCI-devices collector), but I am still unsure about that.

Revision history for this message
Dmitry Tantsur (divius) wrote :

I'm not sure how cleaning is related here, sorry. Just disable the LLDP agent on hardware manager initialization.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/391836
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=ef47d62f4359c5b5a1b3a14a7949fd3992304f13
Submitter: Jenkins
Branch: master

commit ef47d62f4359c5b5a1b3a14a7949fd3992304f13
Author: Szymon Borkowski <email address hidden>
Date: Wed Nov 23 17:14:15 2016 +0100

    Add a new Hardware Manager for CNA network card

    This patch adds a new hardware manager, which will disable the embedded
    LLDP agent on Intel CNA network cards in order to allow the gathering of
    LLDP data during the inspection process.

    Change-Id: I572756ac6a7bf67a7f446738ba9d145e1c1bdc48
    Closes-Bug: #1623659

Changed in ironic-python-agent:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic-python-agent 2.0.0

This issue was fixed in the openstack/ironic-python-agent 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.