Move bash scripts to python

Bug #1557542 reported by Jim Rollenhagen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ironic-python-agent
Fix Released
Medium
Unassigned

Bug Description

We currently have some bash scripts in IPA to write the image, shutdown the machine, etc. These aren't unit testable, and require a bunch of error handling to know where they fail (if they fail). We should move them to python with utils.execute() calls as needed.

Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote :

We should probably use ironic-lib to replace write_image, and move any agent-specific optimizations into ironic-lib as well.

Dmitry Tantsur (divius)
Changed in ironic-python-agent:
status: New → Triaged
importance: Undecided → Medium
Changed in ironic-python-agent:
assignee: nobody → Bharath kumar (bharath-kumar3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/372478

Changed in ironic-python-agent:
status: Triaged → In Progress
Revision history for this message
Annie Lezil (annie-lezil) wrote :

Hi Bharath,

Are you still working on this bug. If not, shall I complete it

Annie

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/410486

Changed in ironic-python-agent:
assignee: Bharath kumar (bharath-kumar3) → Annie Lezil (annie-lezil)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic-python-agent (master)

Change abandoned by Annie Lezil (<email address hidden>) on branch: master
Review: https://review.openstack.org/410486
Reason: Sorry I mistakenly uploaded a new patch.

Please review the patch https://review.openstack.org/#/c/372478/

Changed in ironic-python-agent:
assignee: Annie Lezil (annie-lezil) → Jay Faulkner (jason-oldos)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/372478
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=9948349b10b6bb694f92813243598a7a7c84d3f8
Submitter: Jenkins
Branch: master

commit 9948349b10b6bb694f92813243598a7a7c84d3f8
Author: Bharath kumar <email address hidden>
Date: Mon Sep 19 12:41:04 2016 +0000

    Moving Reboot bashscript to python

    Currently a reboot bash script file is used to call reboot and
    poweroff operation. Deleting this file and moving the code to
    python file using utils.execute()

    Partial-Bug: #1557542

    Change-Id: Iad9cd9d15417e9a954d108d2759e6303452fca27
    Author: Bharath kumar <email address hidden>
    Co-Authored-By: Annie Lezil <email address hidden>

Changed in ironic-python-agent:
assignee: Jay Faulkner (jason-oldos) → nobody
Vladyslav Drok (vdrok)
Changed in ironic-python-agent:
status: In Progress → Triaged
Changed in ironic-python-agent:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.