Vague error when neither tgt not linux-io are available

[Dmitry Tantsur]

This is how it looks:

2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor [-] Asynchronous exception for node 5acd6516-5d7b-47e8-8fd6-467fe40d2026: Node failed to get image for deploy. exception: Failed to deploy instance: Failed to start the iSCSI target to deploy the node 5acd6516-5d7b-47e8-8fd6-467fe40d2026. Error: {u'message': u'[Errno 2] No such file or directory', u'code': 500, u'type': u'OSError', u'details': u''}
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor Traceback (most recent call last):
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor File "/usr/lib/python2.7/site-packages/ironic/drivers/modules/agent_base_vendor.py", line 345, in heartbeat
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor self.continue_deploy(task, **kwargs)
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor File "/usr/lib/python2.7/site-packages/ironic/conductor/task_manager.py", line 134, in wrapper
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor return f(*args, **kwargs)
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor File "/usr/lib/python2.7/site-packages/ironic/drivers/modules/iscsi_deploy.py", line 873, in continue_deploy
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor uuid_dict_returned = do_agent_iscsi_deploy(task, self._client)
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor File "/usr/lib/python2.7/site-packages/ironic/drivers/modules/iscsi_deploy.py", line 443, in do_agent_iscsi_deploy
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor raise exception.InstanceDeployFailure(reason=msg)
2016-02-02 14:03:07.812 18301 ERROR ironic.drivers.modules.agent_base_vendor InstanceDeployFailure: Failed to deploy instance: Failed to start the iSCSI target to deploy the node 5acd6516-5d7b-47e8-8fd6-467fe40d2026. Error: {u'message': u'[Errno 2] No such file or directory', u'code': 500, u'type': u'OSError', u'details': u''}

We should detect this situation and return a better error instead.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/282984

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/282984
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=c716293cbfeaae56de714aa0294a9c614578a805
Submitter: Jenkins
Branch: master

commit c716293cbfeaae56de714aa0294a9c614578a805
Author: Zhenguo Niu <email address hidden>
Date: Mon Feb 22 14:56:34 2016 +0800

    Catch OSError as well to return a better error message

    When neither tgt nor linux-io are available, we only get error
    message like 'No such file or directory', this situation should
    be detected and return a better error instead.

    Change-Id: I334717a1a8a728aa6da6024ff9fc6d817399a41f
    Closes-Bug: #1540958

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/ironic-python-agent 1.2.0 release.